New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-toastr version causing duplicate react packages in bundle #969

Closed
ianks opened this Issue Jan 18, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@ianks
Contributor

ianks commented Jan 18, 2017

Currently, allenfeng/react-toastr locks in React like so:

"react": "^0.14.0 || <15.4.0"

However, I am currently using react 15.4.1, so I have duplicate React packages in my bundle. Thus, react-toastr comprise 5.65% of my bundle. Funnily enough, I don't even use the toastr parts of this package :/

font-awesome: 1.42 MB (13.0%)
lodash: 688.56 KB (6.14%)
@allenfang/react-toastr: 633.7 KB (5.65%)
  react: 580.18 KB (91.6%)
  fbjs: 32.93 KB (5.20%)
  react-dom: 63 B (0.00971%)
  <self>: 20.53 KB (3.24%)

Can you upgrade the dep to allow for newer versions of react?

@AllenFang

This comment has been minimized.

Owner

AllenFang commented Jan 18, 2017

I saw you comment on #838, close this one and answer there

@AllenFang

This comment has been minimized.

Owner

AllenFang commented Apr 11, 2017

please check #1216, if you have any concern or question, let me know in #1216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment