From 049041ac5293efc1066c473f4765330e7eb04aae Mon Sep 17 00:00:00 2001 From: Bin Fan Date: Tue, 6 Mar 2018 19:11:30 -0800 Subject: [PATCH] Fix LOG.warn without context (#6924) --- .../java/alluxio/master/file/DefaultFileSystemMaster.java | 2 +- .../src/main/java/alluxio/worker/block/SpaceReserver.java | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/core/server/master/src/main/java/alluxio/master/file/DefaultFileSystemMaster.java b/core/server/master/src/main/java/alluxio/master/file/DefaultFileSystemMaster.java index 283b5b903bd8..3d847b3ba27c 100644 --- a/core/server/master/src/main/java/alluxio/master/file/DefaultFileSystemMaster.java +++ b/core/server/master/src/main/java/alluxio/master/file/DefaultFileSystemMaster.java @@ -1504,7 +1504,7 @@ private List> deleteInternal(LockedInodePath inodePath, boolean replaye failedToDelete = !ufsDeleter.delete(alluxioUriToDel, delInode); } } catch (InvalidPathException e) { - LOG.warn(e.getMessage()); + LOG.warn("Failed to delete path from UFS: {}", e.getMessage()); } } if (!failedToDelete) { diff --git a/core/server/worker/src/main/java/alluxio/worker/block/SpaceReserver.java b/core/server/worker/src/main/java/alluxio/worker/block/SpaceReserver.java index f59adbac454f..3a7c689d9d9c 100644 --- a/core/server/worker/src/main/java/alluxio/worker/block/SpaceReserver.java +++ b/core/server/worker/src/main/java/alluxio/worker/block/SpaceReserver.java @@ -102,8 +102,8 @@ private void reserveSpace() { mBlockWorker.freeSpace(Sessions.MIGRATE_DATA_SESSION_ID, reservedSpace, tierAlias); } catch (WorkerOutOfSpaceException | BlockDoesNotExistException | BlockAlreadyExistsException | InvalidWorkerStateException | IOException e) { - LOG.warn("SpaceReserver failed to free tier {} to {} bytes used", tierAlias, - reservedSpace, e.getMessage()); + LOG.warn("SpaceReserver failed to free tier {} to {} bytes used for high watermarks: " + + "{}", tierAlias, reservedSpace, e.getMessage()); } } } else { @@ -111,7 +111,8 @@ private void reserveSpace() { mBlockWorker.freeSpace(Sessions.MIGRATE_DATA_SESSION_ID, reservedSpace, tierAlias); } catch (WorkerOutOfSpaceException | BlockDoesNotExistException | BlockAlreadyExistsException | InvalidWorkerStateException | IOException e) { - LOG.warn(e.getMessage()); + LOG.warn("SpaceReserver failed to free tier {} to {} bytes used: {}", tierAlias, + reservedSpace, e.getMessage()); } } }