Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf version #14831

Merged
merged 1 commit into from Jan 17, 2022
Merged

Update protobuf version #14831

merged 1 commit into from Jan 17, 2022

Conversation

ddadaal
Copy link
Contributor

@ddadaal ddadaal commented Jan 11, 2022

What changes are proposed in this pull request?

Try updating protobuf to resolve some CVEs.

Why are the changes needed?

Some CVEs are caused by protobuf version. This PR updates protobuf to a fixed version.

Does this PR introduce any user facing changes?

No

Copy link
Contributor

@yuzhu yuzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. LGTM

@ddadaal
Copy link
Contributor Author

ddadaal commented Jan 12, 2022

Java 8 Integration test (module (alluxio.client.fs.,!alluxio.client.fs.concurrent.,!alluxio.client.fs.io.**)) reports no test failure but the following compilation error

2022-01-11T15:56:55.9674636Z 15:56:55.960 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project alluxio-integration-yarn: Compilation failure: Compilation failure: 
2022-01-11T15:56:55.9676655Z 15:56:55.966 [ERROR] error reading /home/jenkins/.m2/repository/org/apache/hadoop/hadoop-yarn-api/3.3.0/hadoop-yarn-api-3.3.0.jar; zip file is empty
2022-01-11T15:56:55.9678269Z 15:56:55.966 [ERROR] error reading /home/jenkins/.m2/repository/org/apache/hadoop/hadoop-yarn-api/3.3.0/hadoop-yarn-api-3.3.0.jar; zip file is empty
2022-01-11T15:56:55.9679903Z 15:56:55.966 [ERROR] /usr/src/alluxio/integration/yarn/src/test/java/alluxio/yarn/ClientTest.java:[23,50] package org.apache.hadoop.yarn.api.protocolrecords does not exist
2022-01-11T15:56:55.9688111Z 15:56:55.966 [ERROR] /usr/src/alluxio/integration/yarn/src/test/java/alluxio/yarn/ClientTest.java:[24,42] package org.apache.hadoop.yarn.api.records does not exist
2022-01-11T15:56:55.9696393Z 15:56:55.968 [ERROR] /usr/src/alluxio/integration/yarn/src/test/java/alluxio/yarn/ClientTest.java:[171,38] cannot find symbol
2022-01-11T15:56:55.9697140Z 15:56:55.969 [ERROR]   symbol:   class Resource
2022-01-11T15:56:55.9697771Z 15:56:55.969 [ERROR]   location: class alluxio.yarn.ClientTest
2022-01-11T15:56:55.9708517Z 15:56:55.969 [ERROR] /usr/src/alluxio/integration/yarn/src/test/java/alluxio/yarn/ContainerAllocatorTest.java:[23,42] package org.apache.hadoop.yarn.api.records does not exist
2022-01-11T15:56:55.9710418Z 15:56:55.970 [ERROR] /usr/src/alluxio/integration/yarn/src/test/java/alluxio/yarn/ContainerAllocatorTest.java:[24,42] package org.apache.hadoop.yarn.api.records does not exist
2022-01-11T15:56:55.9718613Z 15:56:55.970 [ERROR] /usr/src/alluxio/integration/yarn/src/test/java/alluxio/yarn/ContainerAllocatorTest.java:[25,42] package org.apache.hadoop.yarn.api.records does not exist
2022-01-11T15:56:55.9727509Z 15:56:55.971 [ERROR] /usr/src/alluxio/integration/yarn/src/test/java/alluxio/yarn/ContainerAllocatorTest.java:[26,42] package org.apache.hadoop.yarn.api.records does not exist
2022-01-11T15:56:55.9734427Z 15:56:55.972 [ERROR] /usr/src/alluxio/integration/yarn/src/test/java/alluxio/yarn/ContainerAllocatorTest.java:[27,42] package org.apache.hadoop.yarn.api.records does not exist
2022-01-11T15:56:55.9741590Z 15:56:55.973 [ERROR] /usr/src/alluxio/integration/yarn/src/test/java/alluxio/yarn/ContainerAllocatorTest.java:[31,35] cannot find symbol
2022-01-11T15:56:55.9786486Z 15:56:55.973 [ERROR]   symbol:   class Records
2022-01-11T15:56:55.9787201Z 15:56:55.976 [ERROR]   location: package org.apache.hadoop.yarn.util
2022-01-11T15:56:55.9788363Z 15:56:55.976 [ERROR] /usr/src/alluxio/integration/yarn/src/test/java/alluxio/yarn/ContainerAllocatorTest.java:[52,11] cannot find symbol
2022-01-11T15:56:55.9789213Z 15:56:55.977 [ERROR]   symbol:   class Resource
2022-01-11T15:56:55.9790013Z 15:56:55.977 [ERROR]   location: class alluxio.yarn.ContainerAllocatorTest
2022-01-11T15:56:55.9791198Z 15:56:55.977 [ERROR] /usr/src/alluxio/integration/yarn/src/test/java/alluxio/yarn/ContainerAllocatorTest.java:[131,11] cannot find symbol
2022-01-11T15:56:55.9792118Z 15:56:55.977 [ERROR]   symbol:   class ContainerAllocator
2022-01-11T15:56:55.9793098Z 15:56:55.977 [ERROR]   location: class alluxio.yarn.ContainerAllocatorTest
2022-01-11T15:56:55.9794291Z 15:56:55.977 [ERROR] /usr/src/alluxio/integration/yarn/src/test/java/alluxio/yarn/ContainerAllocatorTest.java:[170,54] cannot find symbol
2022-01-11T15:56:55.9795453Z 15:56:55.977 [ERROR]   symbol:   class ContainerAllocator
2022-01-11T15:56:55.9796304Z 15:56:55.977 [ERROR]   location: class alluxio.yarn.ContainerAllocatorTest
2022-01-11T15:56:55.9797501Z 15:56:55.978 [ERROR] /usr/src/alluxio/integration/yarn/src/test/java/alluxio/yarn/ContainerAllocatorTest.java:[186,51] cannot find symbol
2022-01-11T15:56:55.9798353Z 15:56:55.978 [ERROR]   symbol:   class Container
2022-01-11T15:56:55.9799147Z 15:56:55.978 [ERROR]   location: class alluxio.yarn.ContainerAllocatorTest

@ddadaal
Copy link
Contributor Author

ddadaal commented Jan 12, 2022

The other 2 failed checks report the following test case failures:

All are in the sheet.

@LuQQiu
Copy link
Contributor

LuQQiu commented Jan 12, 2022

compilation error is real error. @apc999 @madanadit can we fully remove integration/yarn or is there sb still using it?

@madanadit
Copy link
Contributor

madanadit commented Jan 12, 2022 via email

Copy link
Contributor

@yyongycy yyongycy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuzhu
Copy link
Contributor

yuzhu commented Jan 13, 2022

@ddadaal could you create a PR to remove integration/yarn

@yyongycy
Copy link
Contributor

@yuzhu is this one good for checkin so far?

@yuzhu yuzhu closed this Jan 17, 2022
@yuzhu yuzhu reopened this Jan 17, 2022
@yuzhu
Copy link
Contributor

yuzhu commented Jan 17, 2022

FileOutStreamIntegrationTest.cancelWrite:248 expected:<0> but was:<1000> known test error

@yuzhu
Copy link
Contributor

yuzhu commented Jan 17, 2022

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 176152c into Alluxio:master Jan 17, 2022
alluxio-bot pushed a commit that referenced this pull request Jan 20, 2022
### What changes are proposed in this pull request?

Remove integration/yarn as requested in
#14831 (comment)

### Why are the changes needed?

integration/yarn is not needed but introduces several vulnerabilities.

### Does this PR introduce any user facing changes?

No.

pr-link: #14860
change-id: cid-b45432272a8cfa7509ab39e75975d5c960eb230a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants