Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ttlaction back to free #17039

Merged
merged 1 commit into from Mar 9, 2023
Merged

Set ttlaction back to free #17039

merged 1 commit into from Mar 9, 2023

Conversation

ssyssy
Copy link
Contributor

@ssyssy ssyssy commented Mar 8, 2023

What changes are proposed in this pull request?

Set the ttlAction back to free to fix the backward compatibility issue from our daily sanity test.

Why are the changes needed?

Fix the backward compatibility proto issue from a previous PR
#16823.

Does this PR introduce any user facing changes?

No.

@alluxio-bot alluxio-bot added the API Change Changes covering public API label Mar 8, 2023
@ssyssy ssyssy requested a review from jja725 March 8, 2023 22:11
@jja725
Copy link
Contributor

jja725 commented Mar 8, 2023

If we only set the property default value to free, would that resolve the backward compatibility?

@ssyssy
Copy link
Contributor Author

ssyssy commented Mar 9, 2023

If we only set the property default value to free, would that resolve the backward compatibility?
@jja725 it should resolve the backward compatibility.

Copy link
Contributor

@jja725 jja725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.setDescription("When file's ttl is expired, the action performs on it. Options: "
+ "DELETE_ALLUXIO(default), FREE or DELETE")
+ "FREE(default) or DELETE")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still have delete alluxio

@Xenorith
Copy link
Contributor

Xenorith commented Mar 9, 2023

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit ce54336 into master Mar 9, 2023
19 checks passed
@Xenorith Xenorith added area-client Alluxio client breaks-compatibility Potentially breaks forward or backward compatibility labels Mar 22, 2023
jiacheliu3 pushed a commit to jiacheliu3/alluxio that referenced this pull request May 17, 2023
### What changes are proposed in this pull request?

Set the ttlAction back to free to fix the backward compatibility issue
from our daily sanity test.

### Why are the changes needed?
Fix the backward compatibility proto issue from a previous PR
Alluxio#16823.

### Does this PR introduce any user facing changes?

No.

pr-link: Alluxio#17039
change-id: cid-887a9d5ddfe7f4f9e0b929a83f529278b1d9bd90
jiacheliu3 pushed a commit to jiacheliu3/alluxio that referenced this pull request May 17, 2023
### What changes are proposed in this pull request?

Set the ttlAction back to free to fix the backward compatibility issue
from our daily sanity test.

### Why are the changes needed?
Fix the backward compatibility proto issue from a previous PR
Alluxio#16823.

### Does this PR introduce any user facing changes?

No.

pr-link: Alluxio#17039
change-id: cid-887a9d5ddfe7f4f9e0b929a83f529278b1d9bd90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Change Changes covering public API area-client Alluxio client breaks-compatibility Potentially breaks forward or backward compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants