Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCFIX] Add Table of contents nav bar on right side of page #17749

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

Zijian-Zhu
Copy link
Contributor

The right side bar will stay at the same position while scrolling.
example without actually format:
image
with actually format:
image

@Zijian-Zhu Zijian-Zhu requested a review from Xenorith July 7, 2023 21:28
@@ -73,10 +73,15 @@
</div>
</div>

<div class="col-9" id="content">
<div class="col-6" id="content">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shrinking this to 2/3 the original size seems to be a bit narrow. we can merge this for now but i think we should consider making the other sections more narrow too to make more space for the content. the font size and spacing may need to be reduced for the two side bars

@Zijian-Zhu Zijian-Zhu added the type-docs Documentation Defects label Jul 10, 2023
@Zijian-Zhu
Copy link
Contributor Author

alluxio-bot, merge this please

@alluxio-bot alluxio-bot merged commit 08afecc into Alluxio:main Jul 10, 2023
6 checks passed
@Xenorith
Copy link
Contributor

@ccmao1130 fyi

Zijian-Zhu added a commit that referenced this pull request Jul 12, 2023
The right side bar will stay at the same position while scrolling.
example without actually format:
![image](https://github.com/Alluxio/alluxio/assets/107361923/eba16e35-a180-4734-80ee-6d31acc360a2)
with actually format:
![image](https://github.com/Alluxio/alluxio/assets/107361923/01d62af9-7b93-4676-b82f-599a65722f14)

			pr-link: #17749
			change-id: cid-240f63f35d9b18183833eb93b8f8568ef33a55c0
Zijian-Zhu added a commit that referenced this pull request Jul 12, 2023
The right side bar will stay at the same position while scrolling.
example without actually format:
![image](https://github.com/Alluxio/alluxio/assets/107361923/eba16e35-a180-4734-80ee-6d31acc360a2)
with actually format:
![image](https://github.com/Alluxio/alluxio/assets/107361923/01d62af9-7b93-4676-b82f-599a65722f14)

			pr-link: #17749
			change-id: cid-240f63f35d9b18183833eb93b8f8568ef33a55c0
@Zijian-Zhu Zijian-Zhu deleted the toc branch July 26, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-docs Documentation Defects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants