New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ALLUXIO-51] Provide C++ binding #6514

Merged
merged 48 commits into from Mar 8, 2018

Conversation

Projects
None yet
7 participants
@Lichongjie
Contributor

Lichongjie commented Nov 23, 2017

this commit focus on the jire task: https://alluxio.atlassian.net/browse/ALLUXIO-51

@alluxio-bot

This comment has been minimized.

Collaborator

alluxio-bot commented Nov 23, 2017

Automated checks report:

Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Nov 23, 2017

Merged build finished. Test FAILed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Nov 23, 2017

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17711/
Test FAILed.

@alluxio-bot

This comment has been minimized.

Collaborator

alluxio-bot commented Nov 24, 2017

Automated checks report:

Please fix the reported issues and reply 'alluxio-bot, check this please' to re-run checks

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Nov 24, 2017

Merged build finished. Test FAILed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Nov 24, 2017

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Nov 24, 2017

Merged build finished. Test PASSed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Nov 24, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17724/
Test PASSed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Nov 24, 2017

Merged build finished. Test PASSed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Nov 24, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17725/
Test PASSed.

@Lichongjie

This comment has been minimized.

Contributor

Lichongjie commented Nov 24, 2017

Jenkins, test this please.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Nov 24, 2017

Merged build finished. Test PASSed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Nov 24, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17726/
Test PASSed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Nov 24, 2017

Merged build finished. Test PASSed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Nov 24, 2017

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17727/
Test PASSed.

@Lichongjie Lichongjie changed the title from [WIP ALLUXIO-51] Provide C++ binding to [ALLUXIO-51] Provide C++ binding Nov 24, 2017

@alluxio-bot

This comment has been minimized.

Collaborator

alluxio-bot commented Nov 24, 2017

Automated checks report:

  • Valid pull request title: PASS
  • Contains link to JIRA ticket: PASS
  • Commits associated with Github account: PASS

All checks passed!

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Nov 24, 2017

Merged build finished. Test PASSed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Feb 9, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18586/
Test PASSed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Feb 9, 2018

Merged build finished. Test PASSed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Feb 9, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18587/
Test PASSed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Feb 9, 2018

Merged build finished. Test PASSed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Feb 9, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18588/
Test PASSed.

@yupeng9

Thanks for the update. I left a question on the performance.

Also, can you add a section to the docs under section Clients, similar to this one https://alluxio.org/docs/1.7/en/Clients-Alluxio-Java.html

@@ -1,15 +1,23 @@
# Alluxio C++ API
### environment variables configuration
### Introduction
The C++ client is implemented through JNI to native Java client. The

This comment has been minimized.

@yupeng9

yupeng9 Feb 9, 2018

Collaborator

@Lichongjie I'm not sure about this statement. Did you run some experiment to verify it? Typically there is performance overhead when programming language barrier is crossed. For example, libhdfs incurs a 30% perf overhead comparing to native HDFS client.

### Run the test case function in FileSystemTest
- Coding example
```

This comment has been minimized.

@yupeng9

yupeng9 Feb 9, 2018

Collaborator

"```C++"

pom.xml Outdated
@@ -1108,7 +1108,8 @@
<exclude>**/src/proto/**</exclude>
<exclude>**/src/deb/**/*</exclude>
<exclude>**/src/test/resources/**</exclude>
<exclude>**/vagrant/**/*</exclude>
<exclude>**/vagrant/**/*</exclude>
<exclude>**/cpplint.py</exclude>

This comment has been minimized.

@yupeng9

yupeng9 Feb 9, 2018

Collaborator

Can this linter be triggered by maven?

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Feb 28, 2018

Merged build finished. Test PASSed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Feb 28, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18744/
Test PASSed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Feb 28, 2018

Merged build finished. Test PASSed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Feb 28, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18745/
Test PASSed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Feb 28, 2018

Merged build finished. Test PASSed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Feb 28, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18747/
Test PASSed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Feb 28, 2018

Merged build finished. Test PASSed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Feb 28, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18748/
Test PASSed.

@Lichongjie

This comment has been minimized.

Contributor

Lichongjie commented Feb 28, 2018

@uronce-cc @yupeng9 @apc999 PTAL, thanks

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Feb 28, 2018

Merged build finished. Test PASSed.

@AmplabJenkins

This comment has been minimized.

AmplabJenkins commented Feb 28, 2018

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18749/
Test PASSed.

@yupeng9

This comment has been minimized.

Collaborator

yupeng9 commented Mar 5, 2018

LGTM. Thanks for adding this important feature!

@yupeng9

yupeng9 approved these changes Mar 5, 2018

@apc999

This comment has been minimized.

Collaborator

apc999 commented Mar 6, 2018

@Lichongjie one comment left about the change in bin/alluxio. Otherwise this PR looks good to me

@apc999

apc999 approved these changes Mar 8, 2018

@apc999 apc999 merged commit 5bac80b into Alluxio:cpp Mar 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment