Fix plugins check #53

Open
wants to merge 2 commits into
from

Conversation

Projects
None yet
1 participant

tdivis commented Apr 6, 2012

Check for required_sane_plugins, called from is_skipped() in startTest
was causing errors because not all plugins were enabled at that time
(startTest methods of all plugins are called sequentially), so enable_test
had to be moved to beforeTest plugin method.

This was revealed by failing test testproject.test.test_database.TestFixturesLoadedProperly.test_model_loaded, which now passes.

Tomas Divis added some commits Mar 18, 2012

Tomas Divis Big cleanup
 * Fixed some unresolved imports and undefined variables
 * Removed lot of unused imports and variables, removed some re-imports
 * PEP8-ify white spaces, removed trailing spaces, blank lines are blank etc.
 * Added some false positive error/warning disabling for pylint and pydev
 * Did some refactoring to remove code duplication
 * Fixed lot of object's attributes were not defined in __init__
 * Refactored some variable names to code be more readable
 * Removed some variables redefinitions (either build-ins and few locals)
0196efe
Tomas Divis Fixed required_sane_plugins check
Check for required_sane_plugins, called from is_skipped() in startTest
was causing errors because not all plugins were enabled at that time
(startTest methods of all plugins are called sequentially), so enable_test
had to be moved to beforeTest plugin method.

This was revealed by failing test testproject.test.test_database.TestFixturesLoadedProperly.test_model_loaded, which now passes.
b9460d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment