Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for transparency #31

Merged
merged 5 commits into from Aug 8, 2019

Conversation

@Aloxaf
Copy link
Owner

commented Aug 8, 2019

Close #23

@Aloxaf

This comment has been minimized.

Copy link
Owner Author

commented Aug 8, 2019

It seems to work well

silicon sample.rs -o test.png --background '#00ffffff' 

test

But not compatible with shadow

silicon sample.rs -o test.png --background '#00ffffff' --shadow-blur-radius 20

test

@Aloxaf

This comment has been minimized.

Copy link
Owner Author

commented Aug 8, 2019

Fixed

silicon sample.rs -o test.png --shadow-blur-radius 20 --background '#00000000' --shadow-color '#7f000000'

test

@Aloxaf Aloxaf changed the title Add support for transparent background Add support for transparency Aug 8, 2019

@mys721tx
Copy link

left a comment

It is counterintuitive that the parser uses ARGB instead of RGBA. We should document it or change the behavior of the parser.

@Aloxaf

This comment has been minimized.

Copy link
Owner Author

commented Aug 8, 2019

@mys721tx In fact, I am also somewhat uncertain whether I should use RRGGBBAA or AARRGGBB. I don't know if there is a standard.
But RGBA is indeed more intuitive.

@Aloxaf Aloxaf merged commit d8085ed into master Aug 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Aloxaf Aloxaf deleted the transparent_background branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.