Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add release, subdomains and renew for ENS #258

Open
wants to merge 9 commits into
base: master
from

Conversation

@James-Sangalli
Copy link
Member

James-Sangalli commented Oct 22, 2019

Ready to merge and release after AlphaWallet/alpha-wallet-ios#1504 & AlphaWallet/alpha-wallet-android#948 & AlphaWallet/alpha-wallet-ios#1515 & fixing getting attributes loaded which depend on other attributes

Update: postponing til we get event support

@James-Sangalli James-Sangalli changed the title add release, subdomains and commented out renew for ENS add release, subdomains and renew for ENS Oct 25, 2019
@James-Sangalli James-Sangalli force-pushed the ens branch 2 times, most recently from e932325 to f3fdbb8 Oct 25, 2019
@hboon

This comment has been minimized.

Copy link
Member

hboon commented Nov 1, 2019

@colourful-land should line 26, currently:

<ts:data name="EventRegistered">

be:

<ts:data name="NameRegistered">

instead; unless line 26 provides a way to describe an artefact's shape, and the artefact is somehow referenced in line 43 in the <ts:ethereum event=> origin tag with an attribute other than name.

examples/ENS/ENS.xml Outdated Show resolved Hide resolved
@James-Sangalli

This comment has been minimized.

Copy link
Member Author

James-Sangalli commented Nov 4, 2019

@colourful-land should line 26, currently:

<ts:data name="EventRegistered">

be:

<ts:data name="NameRegistered">

instead; unless line 26 provides a way to describe an artefact's shape, and the artefact is somehow referenced in line 43 in the <ts:ethereum event=> origin tag with an attribute other than name.

Fixed

@James-Sangalli

This comment has been minimized.

Copy link
Member Author

James-Sangalli commented Nov 4, 2019

@colourful-land we should up the schema and take this opportunity to add array types as well. Maybe hit for 2019/12

@colourful-land

This comment has been minimized.

Copy link
Member

colourful-land commented Dec 2, 2019

Hi I reversed @James-Sangalli .gitnore as I wasn't aware node-js modules are being introduced (sorry). If it is going to be that complicated it should graduate to its own project (instead of in tokenscript/examples). It's good for learners. having learners read long pieces of code and being distracted by production details is a bit like, for the lack of better analogy, like someone splashing coffee on your shirt every 30 minutes when you learn to speak Spanish, regardless if you pronounced correctly.

If that's agreed, this pull request will be about the schema update for ENS and ENS live somewhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.