Small iceberg read optimization #1109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enmk
changed the title
Enmk
reviewed
Oct 30, 2025
| data_lake_metadata = object->data_lake_metadata.value(); | ||
|
|
||
| file_meta_info = object->file_meta_info; | ||
| if (context->getSettingsRef()[Setting::allow_experimental_iceberg_read_optimization]) |
Member
There was a problem hiding this comment.
It feels a bit weird that file_meta_info is created conditionally, if the goal is to to send (or rather NOT send it), modifying ClusterFunctionReadTaskResponse::serialize seems to be more reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Do not send min/max info on swarm nodes when setting
allow_experimental_iceberg_read_optimizationis turned off.Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: