Skip to content

24.3 ci cd fix downloading build reports #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2024
Merged

24.3 ci cd fix downloading build reports #442

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05d7ef0
Make sure that build reports that are downloaded belong to a certain PR
Enmk Aug 16, 2024
fbfad5b
A bit more loging
Enmk Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/ci/ci.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,7 @@ def download_build_reports(self, file_prefix: str = "") -> List[str]:
)
if file_prefix:
path += "_" + file_prefix
logging.info(f"Downloading build reports with prefix '{path}'")
reports_files = self.s3.download_files(
bucket=S3_BUILDS_BUCKET,
s3_path=path,
Expand Down Expand Up @@ -1165,7 +1166,7 @@ def _pre_action(s3, indata, pr_info):
ci_cache = CiCache(s3, indata["jobs_data"]["digests"])

# for release/master branches reports must be from the same branches
report_prefix = normalize_string(pr_info.head_ref) if pr_info.number == 0 else ""
report_prefix = normalize_string(pr_info.head_ref) if pr_info.number == 0 else str(pr_info.number)
print(
f"Use report prefix [{report_prefix}], pr_num [{pr_info.number}], head_ref [{pr_info.head_ref}]"
)
Expand Down