Skip to content

24.3.5-FIPS Publishing server images created by PR #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2024
Merged

24.3.5-FIPS Publishing server images created by PR #443

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d8888a
Publishing server images created by PR
Enmk Aug 19, 2024
810f0dc
Pushing from docker_server.py
Enmk Aug 19, 2024
d90c26c
Attempt to fix pushing the image
Enmk Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions tests/ci/docker_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,9 @@ def build_and_push_image(
init_args = ["docker", "buildx", "build"]
if push:
init_args.append("--push")
init_args.append("--output=type=image,push-by-digest=true")
# NOTE(vnemkov): since for FIPS we don't build arm64 images and don't merge that against amd64 images,
# we don't need to do `push-by-digest`.
init_args.append("--output=type=image")
init_args.append(f"--tag={image.repo}")
else:
init_args.append("--output=type=docker")
Expand Down Expand Up @@ -365,12 +367,19 @@ def main():
del args.image_repo
del args.push

if pr_info.is_master():
push = True
# if pr_info.is_master():
# push = True
# NOTE(vnemkov): always push (since we are pushing to a intermediary repo) for testing
push = True

image = DockerImageData(image_path, image_repo, False)
args.release_type = auto_release_type(args.version, args.release_type)
tags = gen_tags(args.version, args.release_type)

# NOTE(vnemkov): publish docker images created by PRs, so there is a way to test them
if pr_info.is_pr():
tags.append(f'PR-{pr_info.number}-{pr_info.sha}')

repo_urls = {}
direct_urls: Dict[str, List[str]] = {}
release_or_pr, _ = get_release_or_pr(pr_info, args.version)
Expand Down