Fix lint issues #7786
Merged
Fix lint issues #7786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/receipt
|
@jeevananthank This PR contains some refactors, both in altinn-app-frontend and receipt. All tests pass, but not sure if there are any manual verification that should be done as well? |
i think it is fine to merge as long as the regression tests have run ok and there is no functional changes. |
lorang92
approved these changes
Jan 13, 2022
...ltinn.Apps/AppFrontend/react/altinn-app-frontend/src/features/confirm/containers/Confirm.tsx
Show resolved
Hide resolved
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
…oid many subsequent state updates, and add some basic tests
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
…n is deprecated, and avoid logging an error if the request is cancelled
haakemon
force-pushed
the
fix-lint-issues
branch
from
b79c84a
to
5e23bfa
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bunch of eslint issues that cause lots of noise during development
This fixes many eslint issues, adds some more test coverage, and minor refactors to some components that were very outdated.
Some components are refactored a bit more, because of incorrect usage/depenencies for react hooks.
Verification