Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fisk's quest isn't triggered when Mordrag is dead #36

Closed
AmProsius opened this issue Jan 4, 2021 · 3 comments · Fixed by #95 or #218
Closed

Fisk's quest isn't triggered when Mordrag is dead #36

AmProsius opened this issue Jan 4, 2021 · 3 comments · Fixed by #95 or #218
Labels
compatibility: easy impl: modify/analyze script func opinionated type: session fix
Milestone

Comments

@AmProsius
Copy link
Owner

@AmProsius AmProsius commented Jan 4, 2021

Describe the bug
Fisk's quest "New Fence for Fisk" isn't triggered when Mordrag is dead (either killed by the player or by a monster).

Expected behavior
Fisk's quest "New Fence for Fisk" is now also available if Mordrag is dead.

@AmProsius AmProsius added this to To Do in v1.0.0 via automation Jan 4, 2021
@catalinstoian
Copy link

@catalinstoian catalinstoian commented Jan 16, 2021

FUNC int Stt_311_Fisk_MordragKO_Condition()
{
if (MordragKO_HauAb == TRUE)
&& (Npc_GetTrueGuild(hero) == GIL_NONE)
{
return 1;
};
};

changed to

FUNC int  Stt_311_Fisk_MordragKO_Condition()
{
	var C_NPC Mordrag; Mordrag = Hlp_GetNpc(Org_826_Mordrag);
	if (Npc_GetTrueGuild(hero) == GIL_NONE) && ( (MordragKO_HauAb == TRUE) || (MordragKO_StayAtNC==TRUE) || (Npc_IsDead(Mordrag)) )
	{
		return 1;
	};
};

@szapp szapp added type: session fix compatibility: easy labels Jan 24, 2021
szapp added a commit that referenced this issue Feb 1, 2021
szapp added a commit that referenced this issue Feb 1, 2021
AmProsius added a commit that referenced this issue Feb 1, 2021
v1.0.0 automation moved this from To Do to Done Feb 1, 2021
AmProsius added a commit that referenced this issue Feb 1, 2021
#36: Enable Fisk's fence quest
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 9, 2021
@AmProsius AmProsius added the opinionated label Feb 18, 2021
@szapp szapp added this to Info condition (hook) in Fix templates Mar 15, 2021
@szapp szapp added the impl: hook script func label Mar 16, 2021
@szapp szapp moved this from Hook Daedalus function to Unsorted in Fix templates Mar 16, 2021
@szapp szapp moved this from Unsorted to Dialog: Info condition in Fix templates Mar 17, 2021
@AmProsius AmProsius reopened this Mar 29, 2021
@AmProsius AmProsius removed this from the v1.0.0 milestone Mar 29, 2021
@AmProsius AmProsius added this to the v1.1.0 milestone Mar 29, 2021
@AmProsius AmProsius added this to To Do in v1.1.0 via automation Mar 29, 2021
@AmProsius AmProsius changed the title Fisk's quest isn't triggered Fisk's quest isn't triggered when Mordrag is dead Mar 29, 2021
@AmProsius
Copy link
Owner Author

@AmProsius AmProsius commented Mar 29, 2021

As discussed, I want to remove MordragKO_StayAtNC == TRUE from the condition, so only Npc_IsDead(Mordrag) is added.

@szapp
Copy link
Collaborator

@szapp szapp commented Mar 30, 2021

Looking at how I implemented the fix, it's actually very bad. I was unknowingly overwriting the variable MordragKO_HauAb which is also used elsewhere. Good thing we are revisiting that fix!

szapp added a commit that referenced this issue Mar 30, 2021
@szapp szapp added impl: modify/analyze script func and removed impl: hook script func labels Mar 30, 2021
@szapp szapp moved this from To Do to In Progress in v1.1.0 Mar 30, 2021
@szapp szapp removed their assignment Mar 30, 2021
v1.1.0 automation moved this from In Progress to Done Mar 31, 2021
AmProsius added a commit that referenced this issue Apr 15, 2021
szapp added a commit that referenced this issue Apr 18, 2021
- There are new AI variable setter/getter functions for symbol indices
- There are new info functions for symbol indices
- The testsuite has been separated into multiple files
- The check functions have been extended
- The check functions all return symbol indices
- New find functions return exisiting objects
- New create functions return new objects
- All tests up to #36 have been updated with the new changes
szapp added a commit that referenced this issue Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy impl: modify/analyze script func opinionated type: session fix
Projects
Fix templates
Modify dialog conditions
v1.0.0
  
Done
v1.1.0
  
Done
3 participants