Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard has duplicated END dialog #42

Closed
AmProsius opened this issue Jan 6, 2021 · 2 comments · Fixed by #117
Closed

Guard has duplicated END dialog #42

AmProsius opened this issue Jan 6, 2021 · 2 comments · Fixed by #117
Labels
compatibility: easy impl: hook script func impl: modify/analyze script func provided fix type: session fix
Milestone

Comments

@AmProsius
Copy link
Owner

@AmProsius AmProsius commented Jan 6, 2021

Describe the bug
One of the guards guarding the ore barons' house in the Old Camp has two END dialog options.

Expected behavior
One of the guards guarding the ore barons' house in the Old Camp no longer has two END dialog options.

Additional context
The NPC is GRD_218_Gardist. This issue split two separate issues, the other one being #244.

@AmProsius AmProsius added this to To Do in v1.0.0 via automation Jan 6, 2021
@catalinstoian
Copy link

@catalinstoian catalinstoian commented Jan 16, 2021

instance DIA_Grd_218_Exit (C_INFO)
{
npc = Grd_218_GArdist;
nr = 999;
condition = DIA_Grd_218_Exit_Condition;
information = DIA_Grd_218_Exit_Info;
permanent = 1;
description = DIALOG_ENDE;
};
FUNC int DIA_Grd_218_Exit_Condition()
{
return 1;
};
FUNC VOID DIA_Grd_218_Exit_Info()
{
AI_StopProcessInfos (self);
};

changed to

/*
instance DIA_Grd_218_Exit (C_INFO)
{
	npc			= Grd_218_GArdist;
	nr			= 999;
	condition	= DIA_Grd_218_Exit_Condition;
	information	= DIA_Grd_218_Exit_Info;
	permanent	= 1;
	description = DIALOG_ENDE;
};                       

FUNC int DIA_Grd_218_Exit_Condition()
{
	return 1;
};

FUNC VOID DIA_Grd_218_Exit_Info()
{
	AI_StopProcessInfos	(self);
};
*/

and

instance DIA_GRD_245_Exit (C_INFO)
{
npc = GRD_245_Gardist;
nr = 999;
condition = DIA_GRD_245_Exit_Condition;
information = DIA_GRD_245_Exit_Info;
permanent = 1;
description = DIALOG_ENDE;
};
FUNC int DIA_GRD_245_Exit_Condition()
{
return 1;
};
FUNC VOID DIA_GRD_245_Exit_Info()
{
AI_StopProcessInfos (self);
};

changed to

/*
instance DIA_GRD_245_Exit (C_INFO)
{
	npc			= GRD_245_Gardist;
	nr			= 999;
	condition	= DIA_GRD_245_Exit_Condition;
	information	= DIA_GRD_245_Exit_Info;
	permanent	= 1;
	description = DIALOG_ENDE;
};                       

FUNC int DIA_GRD_245_Exit_Condition()
{
	return 1;
};

FUNC VOID DIA_GRD_245_Exit_Info()
{
	AI_StopProcessInfos	(self);
};
*/

@szapp szapp added the type: revert on save label Jan 24, 2021
@AmProsius AmProsius changed the title Gardist guards have duplicated END dialog Guards have duplicated END dialog Jan 25, 2021
@AmProsius AmProsius removed this from To Do in v1.0.0 Jan 26, 2021
@AmProsius AmProsius added this to To Do in v1.0.0 Feb 9, 2021
@AmProsius AmProsius added this to the v1.0.0 milestone Feb 9, 2021
@szapp szapp added compatibility: difficult compatibility: easy type: session fix and removed compatibility: difficult type: revert on save labels Feb 9, 2021
@AmProsius AmProsius added the provided fix label Feb 11, 2021
@szapp szapp moved this from To Do to In Progress in v1.0.0 Feb 12, 2021
v1.0.0 automation moved this from In Progress to Done Feb 13, 2021
AmProsius added a commit that referenced this issue Feb 13, 2021
#42: Remove duplicate EXIT dialog from guards
szapp added a commit that referenced this issue Mar 13, 2021
Check if there is ANY exit dialog not only the known ones
@szapp szapp added this to Info condition (hook) in Fix templates Mar 15, 2021
@szapp szapp added impl: hook script func impl: modify/analyze script func labels Mar 16, 2021
@szapp szapp moved this from Hook Daedalus function to Unsorted in Fix templates Mar 16, 2021
@szapp szapp moved this from Unsorted to Dialog: Info condition in Fix templates Mar 17, 2021
szapp added a commit that referenced this issue Mar 17, 2021
AmProsius added a commit that referenced this issue Apr 19, 2021
@AmProsius
Copy link
Owner Author

@AmProsius AmProsius commented Jul 22, 2021

This issue was split into two separate issues (see #244).

AmProsius added a commit that referenced this issue Jul 22, 2021
@AmProsius AmProsius changed the title Guards have duplicated END dialog Guard has duplicated END dialog Jul 22, 2021
AmProsius added a commit that referenced this issue Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy impl: hook script func impl: modify/analyze script func provided fix type: session fix
Projects
Fix templates
Modify dialog conditions
v1.0.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants