Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling - Improved Ore Armor (DE/EN) #149

Merged
merged 5 commits into from Mar 21, 2021
Merged

Spelling - Improved Ore Armor (DE/EN) #149

merged 5 commits into from Mar 21, 2021

Conversation

AmProsius
Copy link
Owner

@AmProsius AmProsius commented Mar 20, 2021

Describe the bug
In the German and English localization there's a typo in the Improved Ore Armor's name.

Changelog

  • Den Namen "verbesserte Erzrüstung" korrigiert zu "Verbesserte Erzrüstung".
  • Changed the name "Improved ore Armor" to "Improved Ore Armor".

@AmProsius AmProsius added the validation: required label Feb 24, 2021
@AmProsius
Copy link
Owner Author

@AmProsius AmProsius commented Feb 24, 2021

changed to

name 					=	"Verbesserte Erzrüstung";

@AmProsius AmProsius added provided fix language dependent validation: validated and removed validation: required labels Feb 24, 2021
@AmProsius AmProsius added this to To Do in v1.1.0 via automation Feb 24, 2021
@AmProsius AmProsius added this to the v1.1.0 milestone Feb 24, 2021
@AmProsius AmProsius added this to Item name in Fix templates Mar 1, 2021
@szapp szapp added the impl: replace assign/push str label Mar 17, 2021
@szapp szapp added the type: session fix label Mar 17, 2021
@AmProsius AmProsius changed the title Spelling - Improved Ore Armor (DE) Spelling - Improved Ore Armor (DE/EN) Mar 20, 2021
@AmProsius AmProsius requested a review from szapp Mar 20, 2021
v1.1.0 automation moved this from To Do to In Progress Mar 20, 2021
szapp
szapp approved these changes Mar 20, 2021
*
* The text of the item "ORE_ARMOR_H" is inspected programmatically.
*
* Expected behavior: The armor will have the correct description (checked for English and German localization only).
Copy link
Collaborator

@szapp szapp Mar 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it says "description" but it is the name in this fix. Maybe we should make these comments more generic. I think it is very tedious to adjust these comments every time (or potentially have to go back and fix them if we forgot). We can keep that in mind going forward.

@AmProsius AmProsius requested a review from szapp Mar 21, 2021
Copy link
Collaborator

@szapp szapp left a comment

The test fails for German localization. It seems the file test149.d is not encoded in Windows-1252. And the string "Verbesserte Erzrüstung" (including the umlaut) won't match. Otherwise all good.

@AmProsius AmProsius requested a review from szapp Mar 21, 2021
szapp
szapp approved these changes Mar 21, 2021
Copy link
Collaborator

@szapp szapp left a comment

Test passes for German and English localization

@szapp szapp merged commit e0f8ed2 into master Mar 21, 2021
v1.1.0 automation moved this from In Progress to Done Mar 21, 2021
@szapp szapp deleted the bug149 branch Mar 21, 2021
@szapp szapp restored the bug149 branch Mar 21, 2021
@szapp szapp deleted the bug149 branch Mar 21, 2021
@szapp szapp added the compatibility: easy label Mar 21, 2021
szapp added a commit that referenced this issue Apr 20, 2021
@szapp szapp moved this from Instance variable (string) to Item instance variable (string) in Fix templates Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy impl: replace assign/push str language dependent provided fix type: session fix validation: validated
Projects
Fix templates
Change item instance variable (string)
v1.1.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants