Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gor Na Bar offers to become a templar to anyone #168

Merged
merged 2 commits into from Aug 12, 2021
Merged

Gor Na Bar offers to become a templar to anyone #168

merged 2 commits into from Aug 12, 2021

Conversation

AmProsius
Copy link
Owner

@AmProsius AmProsius commented Jul 31, 2021

Describe the bug
No matter the player's guild, Gor Na Bar tells him to speak to Cor Angar about becoming a templar and a log entry is created.

Expected behavior
Gor Na Bar now tells only novices to speak to Cor Angar about becoming a templar.

@AmProsius AmProsius added validation: required provided fix labels Feb 28, 2021
@AmProsius
Copy link
Owner Author

@AmProsius AmProsius commented Feb 28, 2021

FUNC int Tpl_1400_GorNaBar_VICTORY_Condition()
{
if Npc_HasItems (hero,ItAt_Crawlerqueen ) >= 1
{
return TRUE;
};
};

changed to

FUNC int  Tpl_1400_GorNaBar_VICTORY_Condition()
{
    if (Npc_HasItems (hero,ItAt_Crawlerqueen ) >= 1)
    && (Npc_GetTrueGuild (hero) == GIL_NOV)
    {
        return TRUE;
    };


};

@AmProsius AmProsius added opinionated and removed opinionated labels Mar 1, 2021
@szapp szapp added compatibility: easy impl: hook script func type: session fix labels Apr 5, 2021
@szapp szapp added this to Dialog: Info condition in Fix templates Apr 5, 2021
@szapp szapp added this to To Do in v1.2.0 via automation Apr 22, 2021
@szapp szapp added this to the v1.2.0 milestone Apr 22, 2021
@AmProsius AmProsius requested a review from szapp Jul 31, 2021
@AmProsius AmProsius removed their assignment Jul 31, 2021
@AmProsius AmProsius moved this from To Do to In Progress in v1.2.0 Jul 31, 2021
@AmProsius AmProsius added validation: validated and removed validation: required labels Jul 31, 2021
@AmProsius AmProsius requested a review from szapp Aug 10, 2021
szapp
szapp approved these changes Aug 11, 2021
Copy link
Collaborator

@szapp szapp left a comment

Haven't run the test, but the code looks good to me.

@AmProsius AmProsius merged commit 3db5d66 into master Aug 12, 2021
@AmProsius AmProsius deleted the bug168 branch Aug 12, 2021
v1.2.0 automation moved this from In Progress to Done Aug 12, 2021
@szapp szapp moved this from Modify dialog conditions to Add dialog conditions in Fix templates Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy impl: hook script func provided fix type: session fix validation: validated
Projects
Fix templates
Add dialog conditions
v1.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants