Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scorpio offers to teach crossbow multiple times #185

Merged
merged 3 commits into from Apr 11, 2021
Merged

Scorpio offers to teach crossbow multiple times #185

merged 3 commits into from Apr 11, 2021

Conversation

AmProsius
Copy link
Owner

@AmProsius AmProsius commented Apr 8, 2021

Describe the bug
Scorpio offers to teach crossbow level 1 multiple times, even if the player already gained that skill.

Expected behavior
Scorpio no longer offers to teach crossbow level 1 if the player already gained that skill.

Steps to reproduce the issue

  1. Learn crossbow level 1 (from him).
  2. Save the game.
  3. Load the save.
  4. Scorpio offers to teach crossbow level 1 again.

@AmProsius AmProsius added type: session fix compatibility: easy validation: required labels Mar 7, 2021
@AmProsius
Copy link
Owner Author

@AmProsius AmProsius commented Mar 7, 2021

FUNC int GRD_205_Scorpio_CROSSBOW_Condition()
{
if (Kapitel >= 4)
|| (Npc_GetTrueGuild (hero) == GIL_GRD)
{
return TRUE;
};
};

changed to

FUNC int  GRD_205_Scorpio_CROSSBOW_Condition()
{
    if ((Kapitel >= 4) || (Npc_GetTrueGuild (hero) == GIL_GRD))
    && (Npc_GetTalentSkill(hero, NPC_TALENT_CROSSBOW) < 1)
    {
        return TRUE;
    };

};

@AmProsius AmProsius added the provided fix label Mar 7, 2021
@AmProsius AmProsius added this to Info condition in Fix templates Mar 7, 2021
@AmProsius AmProsius added this to To Do in v1.1.0 via automation Mar 11, 2021
@AmProsius AmProsius added this to the v1.1.0 milestone Mar 11, 2021
@szapp szapp added the impl: hook script func label Mar 16, 2021
@szapp szapp moved this from Hook Daedalus function to Unsorted in Fix templates Mar 16, 2021
@szapp szapp moved this from Unsorted to Dialog: Info condition in Fix templates Mar 17, 2021
@AmProsius AmProsius self-assigned this Mar 29, 2021
@AmProsius
Copy link
Owner Author

@AmProsius AmProsius commented Apr 1, 2021

Similar to #25.

@AmProsius AmProsius requested a review from szapp Apr 8, 2021
@AmProsius AmProsius removed their assignment Apr 8, 2021
@szapp szapp moved this from To Do to In Progress in v1.1.0 Apr 8, 2021
szapp
szapp approved these changes Apr 11, 2021
Copy link
Collaborator

@szapp szapp left a comment

I updated the fix and test with the new symbol functions. All good, test passes!

@szapp szapp merged commit 6894baf into master Apr 11, 2021
v1.1.0 automation moved this from In Progress to Done Apr 11, 2021
@szapp szapp deleted the bug185 branch Apr 11, 2021
szapp added a commit that referenced this issue Apr 19, 2021
@szapp szapp removed the validation: required label May 14, 2021
@szapp szapp moved this from Modify dialog conditions to Add dialog conditions in Fix templates Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy impl: hook script func provided fix type: session fix
Projects
Fix templates
Add dialog conditions
v1.1.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants