Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gates triggered by switches are stuck after loading #193

Merged
merged 1 commit into from Apr 3, 2021
Merged

Gates triggered by switches are stuck after loading #193

merged 1 commit into from Apr 3, 2021

Conversation

szapp
Copy link
Collaborator

@szapp szapp commented Mar 29, 2021

Describe the bug
After using a switch/lever/winch to close a gate, the switch does not work anymore after loading a game and the gate is stuck.

Expected behavior
Objects activated by switches/levers/winches are no longer stuck after loading a game.

Steps to reproduce the issue

  1. Close a gate by using the respective switch.
  2. Save the game.
  3. Load the game.
  4. The switch state returns to 0 while the gate remains in its triggered state: The gate will be stuck for good.

Additional context
Attached the fix done by szapp 2 years ago.
See also the original post on WoG: https://forum.worldofplayers.de/forum/threads/?p=25954985

@pawbuj1981 pawbuj1981 added the validation: required label Mar 19, 2021
@szapp szapp changed the title the gate switches are being stucked after save/load a game Gates triggered by switches are stuck after loading Mar 19, 2021
@szapp szapp added compatibility: difficult provided fix impl: hook engine func impl: modify engine func type: revert on save labels Mar 19, 2021
@szapp szapp self-assigned this Mar 19, 2021
@szapp
Copy link
Collaborator

@szapp szapp commented Mar 19, 2021

@pawbuj1981 Thanks for the report! Can you give an example gate in the world where we can test it with?

I will revisit the provided fix and try to remember the root of the problem again to make sure we are not introducing bugs with a half-working solution.

@pawbuj1981
Copy link
Author

@pawbuj1981 pawbuj1981 commented Mar 19, 2021

@pawbuj1981
Copy link
Author

@pawbuj1981 pawbuj1981 commented Mar 19, 2021

Szap in the attachement there is the best script version fix we tested in that time ( u made a quite few versions ! ). Ur example from WOG may be obsolete ! Pls try from the attachement as a base.

@szapp
Copy link
Collaborator

@szapp szapp commented Mar 19, 2021

Thanks for providing it! Nevertheless, the relevant script portions are equivalent.

@szapp szapp added this to VOB property in Fix templates Mar 19, 2021
@szapp szapp removed their assignment Mar 29, 2021
@szapp szapp requested a review from AmProsius Mar 29, 2021
@szapp
Copy link
Collaborator

@szapp szapp commented Mar 29, 2021

The test requires manual confirmation:

The gate (that the PC is teleported to) can be opened again after closing it, saving and loading.

Note: The state of the fix (i.e. APPLIED or NOT APPLIED) reflects whether any stuck switches where fixed. If none, the fix will be listed as NOT APPLIED.

@szapp szapp added this to the v1.1.0 milestone Mar 29, 2021
@szapp szapp added this to In Progress in v1.1.0 via automation Mar 29, 2021
@AmProsius AmProsius merged commit 0a032ef into master Apr 3, 2021
v1.1.0 automation moved this from In Progress to Done Apr 3, 2021
@AmProsius AmProsius deleted the bug193 branch Apr 3, 2021
szapp added a commit that referenced this issue Apr 19, 2021
szapp added a commit that referenced this issue Apr 21, 2021
Model retrieval was not checked properly
@szapp szapp removed the validation: required label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: difficult impl: hook engine func impl: modify engine func provided fix type: revert on save
Projects
Fix templates
Change VOB property
v1.1.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants