Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wolf not listed as merchant #205

Merged
merged 2 commits into from Apr 17, 2021
Merged

Wolf not listed as merchant #205

merged 2 commits into from Apr 17, 2021

Conversation

AmProsius
Copy link
Owner

@AmProsius AmProsius commented Apr 16, 2021

Describe the bug
Wolf is not listed in "Diary/General Info/Merchant in the New Camp" if the topic wasn't previously created.

Expected behavior
Wolf is now listed in "Merchant in the New Camp" in the journal.

Additional context
Similar to #37, #203 and #204.

@AmProsius AmProsius added type: revert on save compatibility: difficult validation: required provided fix impl: modify/analyze script func labels Mar 26, 2021
@AmProsius AmProsius added this to the v1.1.0 milestone Mar 26, 2021
@AmProsius AmProsius self-assigned this Mar 26, 2021
@AmProsius AmProsius added this to To Do in v1.1.0 via automation Mar 26, 2021
@AmProsius
Copy link
Owner Author

@AmProsius AmProsius commented Mar 26, 2021

FUNC VOID DIA_Wolf_Hello_Info()
{
AI_Output (other, self,"DIA_Wolf_Hello_15_00"); //Who are you?
AI_Output (self, other,"DIA_Wolf_Hello_09_01"); //I'm Wolf. I make armor.
B_LogEntry (GE_TraderNC,"Wolf supplies the rogues with ARMOR. He's usually in front of his hut in the big living cave.");
};

changed to

FUNC VOID DIA_Wolf_Hello_Info()
{
    AI_Output           (other, self,"DIA_Wolf_Hello_15_00"); //Who are you?
    AI_Output           (self, other,"DIA_Wolf_Hello_09_01"); //I'm Wolf. I make armor.

    Log_CreateTopic(GE_TraderNC, LOG_NOTE);
    B_LogEntry          (GE_TraderNC,"Wolf supplies the rogues with ARMOR. He's usually in front of his hut in the big living cave.");
};

@AmProsius AmProsius added this to Dialog: Info function in Fix templates Mar 26, 2021
@AmProsius AmProsius changed the title Wolf no listed as merchant Wolf not listed as merchant Mar 26, 2021
@pawbuj1981
Copy link

@pawbuj1981 pawbuj1981 commented Apr 9, 2021

Is that issue-fix avalaible only for english version ? Log is in English .

Nevermind. You have added Log_CreateTopic(GE_TeacherNC, LOG_NOTE) and it should solve the issue now.

@AmProsius AmProsius marked this pull request as draft Apr 16, 2021
@AmProsius AmProsius requested a review from szapp Apr 16, 2021
@AmProsius
Copy link
Owner Author

@AmProsius AmProsius commented Apr 16, 2021

Both the fix and the test have not been tested ingame yet.

@AmProsius AmProsius moved this from To Do to In Progress in v1.1.0 Apr 16, 2021
@AmProsius AmProsius marked this pull request as ready for review Apr 16, 2021
@AmProsius AmProsius removed their assignment Apr 16, 2021
szapp
szapp approved these changes Apr 17, 2021
@szapp szapp merged commit cd3fb2b into master Apr 17, 2021
v1.1.0 automation moved this from In Progress to Done Apr 17, 2021
@szapp szapp deleted the bug205 branch Apr 17, 2021
szapp added a commit that referenced this issue Apr 19, 2021
@szapp szapp removed the validation: required label May 14, 2021
@szapp szapp moved this from Modify dialog function to Add missing log creation in Fix templates Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: difficult impl: modify/analyze script func provided fix type: revert on save
Projects
Fix templates
Create log topic in dialog function
v1.1.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants