Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graham doesn't sit at campfire #214

Merged
merged 2 commits into from Mar 31, 2021
Merged

Graham doesn't sit at campfire #214

merged 2 commits into from Mar 31, 2021

Conversation

szapp
Copy link
Collaborator

@szapp szapp commented Mar 31, 2021

Describe the bug
Graham is supposed to sit at the campfire in the evening, but a typo in the waypoint name prevents him from doing so.

Expected behavior
Graham now correctly sits at the campfire in the evening.

Additional context
Bug and fix provided by NikX94.

@AmProsius AmProsius added the validation: required label Mar 28, 2021
@AmProsius
Copy link
Owner Author

@AmProsius AmProsius commented Mar 28, 2021

FUNC VOID Rtn_start_573 ()
{
TA_Sleep (22,30,06,00,"OCR_HUT_76");
TA_SitAround (06,00,07,00,"OCR_OUTSIDE_HUT_76");
TA_StandAround (07,00,11,00,"OCR_OUSIDE_HUT_77_INSERT");
TA_WashSelf (11,00,11,30,"OCR_LAKE_4");
TA_RepairHut (11,30,12,00,"OCR_OUTSIDE_HUT_76");
TA_Boss (12,00,18,00,"OCR_HUT_76");
TA_SitCampfire (18,00,22,30,"OCR_OUSIDE_HUT_77_INSERT");
};

changed to

FUNC VOID Rtn_start_573 ()
{
    TA_Sleep        (22,30,06,00,"OCR_HUT_76");
    TA_SitAround    (06,00,07,00,"OCR_OUTSIDE_HUT_76");
    TA_StandAround  (07,00,11,00,"OCR_OUTSIDE_HUT_77_INSERT");
    TA_WashSelf     (11,00,11,30,"OCR_LAKE_4");
    TA_RepairHut    (11,30,12,00,"OCR_OUTSIDE_HUT_76");
    TA_Boss         (12,00,18,00,"OCR_HUT_76");
    TA_SitCampfire  (18,00,22,30,"OCR_OUTSIDE_HUT_77_INSERT");
};

@AmProsius AmProsius added the provided fix label Mar 28, 2021
@szapp szapp added compatibility: easy impl: replace assign/push str type: session fix labels Mar 28, 2021
@szapp szapp added this to NPC daily routine in Fix templates Mar 31, 2021
@szapp szapp added this to the v1.1.0 milestone Mar 31, 2021
@szapp szapp added this to To Do in v1.1.0 via automation Mar 31, 2021
@szapp szapp self-assigned this Mar 31, 2021
@szapp szapp requested a review from AmProsius Mar 31, 2021
@szapp szapp removed their assignment Mar 31, 2021
@szapp
Copy link
Collaborator

@szapp szapp commented Mar 31, 2021

The test requires manual confirmation. It may happen that Graham still stands around, if the other digger happens to chose to sit at Graham's spot. That's not so likely (only if the PC stands in the way during their change in routines, at 6 PM).

@szapp szapp moved this from To Do to In Progress in v1.1.0 Mar 31, 2021
@szapp szapp mentioned this pull request Mar 31, 2021
@AmProsius AmProsius merged commit 7406330 into master Mar 31, 2021
v1.1.0 automation moved this from In Progress to Done Mar 31, 2021
@AmProsius AmProsius deleted the bug214 branch Mar 31, 2021
szapp added a commit that referenced this issue Apr 19, 2021
@szapp szapp removed the validation: required label May 14, 2021
szapp added a commit that referenced this issue Feb 6, 2022
szapp added a commit that referenced this issue Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy impl: replace assign/push str provided fix type: session fix
Projects
Fix templates
Change daily routine waypoint
v1.1.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants