Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mercenary doesn't guard the palisade #217

Merged
merged 4 commits into from Apr 5, 2021
Merged

Mercenary doesn't guard the palisade #217

merged 4 commits into from Apr 5, 2021

Conversation

AmProsius
Copy link
Owner

@AmProsius AmProsius commented Apr 1, 2021

Describe the bug
A Mercenary is supposed to guard the palisade during the afternoon, but a typo in the waypoint name prevents him from doing so.

Expected behavior
A Mercenary now correctly guards the palisade during the afternoon.

Additional context
Bug and fix provided by NikX94.

@AmProsius AmProsius added the validation: required label Mar 28, 2021
@AmProsius
Copy link
Owner Author

@AmProsius AmProsius commented Mar 28, 2021

FUNC VOID Rtn_FMCstart_750 ()
{
TA_GuardPalisade (01,00,13,00, "FMC_PATH19");
TA_GuardPalisade (13,00,01,00, "FMC_Path19");
};

changed to

FUNC VOID Rtn_FMCstart_750 ()
{
    TA_GuardPalisade    (01,00,13,00, "FMC_PATH19");
    TA_GuardPalisade    (13,00,01,00, "FMC_PATH19");
};

@AmProsius
Copy link
Owner Author

@AmProsius AmProsius commented Mar 28, 2021

I'm not sure if this really is a bug we have to fix. From my understanding, if an NPC doesn't find the next waypoint, he will continue his current routine (which in this case is the exact same action he is supposed to do). Can you confirm this behavior, @szapp?

@AmProsius AmProsius added the provided fix label Mar 28, 2021
@N1kX94
Copy link

@N1kX94 N1kX94 commented Mar 31, 2021

The error will be that the NPC will be located at the old point from the previous routine, but will not do anything. There is also an error in the fact that the NPC can disappear from the world for this time and return back when the point is available.
In Gothic 2, there are NPCs that disappear due to errors in the routine.

This fix will only improve the atmosphere of the game, nothing more.

@szapp szapp added compatibility: easy impl: replace assign/push str type: session fix labels Mar 31, 2021
@szapp szapp added this to NPC daily routine in Fix templates Mar 31, 2021
@AmProsius AmProsius added this to To Do in v1.1.0 via automation Mar 31, 2021
@AmProsius AmProsius self-assigned this Mar 31, 2021
@AmProsius AmProsius added this to the v1.1.0 milestone Mar 31, 2021
@AmProsius AmProsius requested a review from szapp Apr 1, 2021
@AmProsius AmProsius removed their assignment Apr 1, 2021
@szapp szapp moved this from To Do to In Progress in v1.1.0 Apr 1, 2021
Copy link
Collaborator

@szapp szapp left a comment

Test passes, but I have suggestion for the changelog:

CHANGELOG.md Outdated Show resolved Hide resolved
docs/changelog_de.md Outdated Show resolved Hide resolved
@AmProsius AmProsius requested a review from szapp Apr 3, 2021
szapp
szapp approved these changes Apr 5, 2021
@szapp szapp merged commit fa1560d into master Apr 5, 2021
v1.1.0 automation moved this from In Progress to Done Apr 5, 2021
@szapp szapp deleted the bug217 branch Apr 5, 2021
szapp added a commit that referenced this issue Apr 19, 2021
@szapp szapp removed the validation: required label May 14, 2021
szapp added a commit that referenced this issue Feb 6, 2022
szapp added a commit that referenced this issue Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy impl: replace assign/push str provided fix type: session fix
Projects
Fix templates
Change daily routine waypoint
v1.1.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants