Guard has duplicated END dialog #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmProsius
added
the
validation: required
AmProsius
added
compatibility: easy
|
See requested changes in #128. |
szapp
requested changes
Jul 24, 2021
Here are some additional changes. Since this PR is based on the branch of another PR, I am not sure what's the best course of action. Possibly, it's best to fix the things in #128 first, merge that PR and then, in turn, merge master into this PR here, before fixing the things here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Describe the bug
One of the guards guarding the ore barons' house in the Old Camp has two END dialog options.
Expected behavior
One of the guards guarding the ore barons' house in the Old Camp no longer has two END dialog options.
Additional context
The NPC is
GRD_245_Gardist. This issue was created by splitting #42 in two separate issues.