Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploit: Grindstone in the New Camp can be used without sword blade #52

Merged
merged 1 commit into from Mar 28, 2021

Conversation

szapp
Copy link
Collaborator

@szapp szapp commented Mar 28, 2021

Describe the bug
The grindstone in the New Camp can be used without having a sword blade in the inventory.

Expected behavior
The grindstone in the New Camp now correctly requires a sword blade to use.

Additional context
It's currently possible to produce Grobe Schwerter without having Swordblades in the inventory.
This issue was split into two further issues #212 #213.
Add useWithItem with ItMiSwordblade to grindstone at NC_HUT03_OUT_MOVEMENT.

Screenhots
ScreenShot_2021_2_4_23_1_41

@AmProsius AmProsius added this to To Do in v1.0.0 via automation Jan 6, 2021
@AmProsius AmProsius added the type: world bug label Jan 9, 2021
@AmProsius AmProsius removed this from To Do in v1.0.0 Jan 9, 2021
@AmProsius AmProsius added the validation: required label Jan 28, 2021
@AmProsius
Copy link
Owner Author

@AmProsius AmProsius commented Feb 4, 2021

  1. Add useWithItem with ItMiSwordblade to grindstone at NC_HUT03_OUT_MOVEMENT
  2. Add useWithItem with ITMISCOOP to couldron at NC_HUT13_OUT.
  3. Add useWithItem with ITMISCOOP to couldron at NC_HUT21_OUT.

@AmProsius AmProsius changed the title Mobs in New Camp can't be used Mobs in New Camp can be used without corresponding items Feb 4, 2021
@AmProsius AmProsius changed the title Mobs in New Camp can be used without corresponding items MOBs in New Camp can be used without corresponding items Feb 12, 2021
@AmProsius AmProsius added provided fix validation: validated and removed validation: required labels Feb 12, 2021
@szapp szapp added compatibility: easy type: revert on save labels Feb 13, 2021
@AmProsius AmProsius added this to To Do in v1.1.0 Feb 24, 2021
@AmProsius AmProsius added this to the v1.1.0 milestone Feb 24, 2021
@szapp szapp removed the type: revert on save label Mar 1, 2021
@AmProsius AmProsius added this to MOB property in Fix templates Mar 3, 2021
@szapp szapp added impl: unknown impl: change obj var and removed impl: unknown labels Mar 17, 2021
@szapp szapp self-assigned this Mar 18, 2021
@szapp szapp changed the title MOBs in New Camp can be used without corresponding items Grindstone in the New Camp can be used without sword blade Mar 28, 2021
@szapp szapp moved this from To Do to In Progress in v1.1.0 Mar 28, 2021
@szapp szapp requested a review from AmProsius Mar 28, 2021
@szapp
Copy link
Collaborator

@szapp szapp commented Mar 28, 2021

The test is manual. The player is teleported to the grindstone and should no longer be able to use it without a sword blade. What I have not tested yet, is that this change is reverted properly.

@AmProsius AmProsius changed the title Grindstone in the New Camp can be used without sword blade Exploit: Grindstone in the New Camp can be used without sword blade Mar 28, 2021
Copy link
Owner

@AmProsius AmProsius left a comment

The fix is reverted correctly when removing the patch.

@AmProsius AmProsius merged commit d7760f3 into master Mar 28, 2021
v1.1.0 automation moved this from In Progress to Done Mar 28, 2021
@AmProsius AmProsius deleted the bug052 branch Mar 28, 2021
@szapp szapp removed their assignment Mar 29, 2021
AmProsius added a commit that referenced this issue Apr 20, 2021
szapp added a commit that referenced this issue Jan 18, 2022
Finding VOBs by their exact position can now be further narrowed down by
their class. Like before only the first matching VOB will be found. The
function can now also detect light VOBs which where previously ignored.
For details, see the header commment of ent of 'G1CP_FindVobByPosPtr'.
Common class definitions are defined as constants in constants.d. All
affected fixes are updated.

Refs #46 #51 #52 #127 #212 #213 #226
szapp added a commit that referenced this issue Jan 19, 2022
Instead of specifying a class to narrow down the search (see previous
commit), the option is now more versatile: Now the last parameter is a
callback function. It can either be one of the existing class check
functions or a custom function to narrow down the search more flexibly
and potentially based on more or more complex checks.

Refs #46 #51 #52 #127 #212 #213 #226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: easy impl: change obj var provided fix type: world bug validation: validated
Projects
Fix templates
Change VOB property
v1.1.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants