Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player can decelerate falls by fight actions in mid-air #58

Merged
merged 3 commits into from May 8, 2021
Merged

Conversation

szapp
Copy link
Collaborator

@szapp szapp commented Apr 25, 2021

When the player falls down (e.g. a cliff) and has a weapon drawn, he can decelerate the fall by continuously blocking in mid-air.

@AmProsius AmProsius added this to To Do in v1.0.0 via automation Jan 6, 2021
@szapp
Copy link
Collaborator

@szapp szapp commented Jan 24, 2021

Is this fixed by the SystemPack and/or Union?

@AmProsius
Copy link
Owner Author

@AmProsius AmProsius commented Jan 25, 2021

No, this issue is still present. I just tested it to be sure.

ScreenShot_2021_2_4_23_6_8

@szapp szapp added the type: session fix label Jan 25, 2021
@AmProsius AmProsius added the validation: validated label Jan 28, 2021
@AmProsius AmProsius removed this from To Do in v1.0.0 Feb 9, 2021
@szapp szapp self-assigned this Mar 19, 2021
@szapp szapp added compatibility: difficult impl: modify engine func labels Apr 5, 2021
@szapp szapp added this to Other in Fix templates Apr 5, 2021
@szapp
Copy link
Collaborator

@szapp szapp commented Apr 18, 2021

Note: Location of interest 0x61157E in oCAIHuman::FightMelee.

@szapp szapp marked this pull request as draft Apr 25, 2021
@szapp
Copy link
Collaborator

@szapp szapp commented Apr 25, 2021

The fix (and test) are complete, but I noticed, that any fight action can interrupt falling. Therefore, it may makes sense to change the fix. Note: check 0x613F3D in oCAIHuman::PC_ActionMove.

@szapp szapp changed the title Player can decelerate falls by blocking in mid-air Player can decelerate falls by fight actions in mid-air Apr 25, 2021
@szapp szapp removed their assignment Apr 25, 2021
@szapp
Copy link
Collaborator

@szapp szapp commented Apr 25, 2021

No any fight action is inhibited while falling. Falling is determined, if distance between player model and ground is too large - much like the engine does at different points.

@szapp szapp marked this pull request as ready for review Apr 25, 2021
@szapp szapp added this to In Progress in v1.2.0 via automation Apr 25, 2021
@szapp szapp added this to the v1.2.0 milestone Apr 25, 2021
@szapp szapp moved this from Other to Engine mechanics in Fix templates Apr 26, 2021
@AmProsius AmProsius merged commit c780faf into master May 8, 2021
v1.2.0 automation moved this from In Progress to Done May 8, 2021
@AmProsius AmProsius deleted the bug058 branch May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility: difficult impl: modify engine func type: session fix validation: validated
Projects
Fix templates
Modify engine function
v1.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants