Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: computed #85

Merged
merged 1 commit into from
Mar 21, 2023
Merged

feat: computed #85

merged 1 commit into from
Mar 21, 2023

Conversation

divdavem
Copy link
Member

@divdavem divdavem commented Mar 8, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 8, 2023 •
edited
Loading

Codecov Report

Merging #85 (101f6a7) into master (05b5d85) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 101f6a7 differs from pull request most recent head b993c61. Consider uploading reports for the commit b993c61 to get more accurate results

@@            Coverage Diff             @@
##            master       #85    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            1         1            
  Lines          235       349   +114     
  Branches        41        62    +21     
==========================================
+ Hits           235       349   +114
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@divdavem divdavem force-pushed the computed branch 7 times, most recently from b7de1c6 to 1ff7aef Compare March 14, 2023 17:54
@divdavem divdavem requested a review from fbasso March 14, 2023 17:56
@divdavem divdavem force-pushed the computed branch 12 times, most recently from 4a0f0c0 to 101f6a7 Compare March 15, 2023 17:15
@divdavem divdavem marked this pull request as ready for review March 16, 2023 14:20
@divdavem divdavem force-pushed the computed branch 2 times, most recently from 9b3bb77 to 64e17f5 Compare March 21, 2023 14:54
fbasso
fbasso approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@fbasso fbasso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for this nice addition !

@divdavem
Copy link
Member Author

@fbasso Thank you for your review!

@divdavem divdavem merged commit d713430 into AmadeusITGroup:master Mar 21, 2023
@divdavem divdavem mentioned this pull request Mar 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbasso fbasso fbasso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@divdavem @fbasso