Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on latest nightly #309

Merged
merged 1 commit into from
Dec 19, 2021
Merged

Fix build on latest nightly #309

merged 1 commit into from
Dec 19, 2021

Conversation

Amanieu
Copy link
Owner

@Amanieu Amanieu commented Dec 19, 2021

asm! is now stable.

asm! is now stable.
@@ -5,6 +5,8 @@
// http://opensource.org/licenses/MIT>, at your option. This file may not be
// copied, modified, or distributed except according to those terms.

#[cfg(all(feature = "nightly", any(target_arch = "x86", target_arch = "x86_64")))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename the feature to "hardware-lock-elision" now or in a future release?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a future version I will just have this always enabled by default.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't some processors have a bug causing "unpredictable system behavior" (aka crashes or worse) when using hardware lock elision?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's actually a good point, I wasn't aware that HLE was broken on all currently available CPUs.

@Amanieu Amanieu merged commit c73dd43 into master Dec 19, 2021
@Amanieu Amanieu deleted the stable_asm branch December 19, 2021 20:26
@claui claui mentioned this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants