test: add workflow determinism validation#47
Merged
Conversation
…y tests
- Add workflowcheck CI step that gates Docker build on static analysis
- Add opt-in replay test suite (RUN_REPLAY_TESTS=1) with Label("replay")
- Add testdata/README.md with instructions for capturing history fixtures
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflowcheckCI job to.github/workflows/docker-build-push-worker.ymlthat runs static analysis before the Docker build, blocking merges if any workflow code contains non-deterministic constructs (goroutines, map iteration,time.Now(), etc.)internal/workflows/replay_test.gowith replay specs for all 8 workflows — skipped by default, opt-in viaRUN_REPLAY_TESTS=1env var andLabel("replay")Ginkgo filterinternal/workflows/testdata/README.mdwith instructions for capturing workflow history JSON fixtures from a local Temporal dev serverTest plan
go test -v ./internal/workflows/...— replay specs skip automatically (noRUN_REPLAY_TESTSset)workflowcheck ./...returns clean (verified locally)workflowcheckjob passes and gatesbuild-and-pushRUN_REPLAY_TESTS=1 ginkgo -v --label-filter "replay" ./internal/workflows/🤖 Generated with Claude Code