Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upparent being overwritten #30
Comments
bear
added
bug
question
labels
Mar 6, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mmacaula
Apr 27, 2015
This seems related to a bug I'm having as well. From one of the instantiated ItemViews, we used to be able to call this.parent which would be the collectionView, and then this.parent.parent which would be the original View that ran renderCollection(). However, that seems broken now, replaced with this.parent being the original View.
I'm not smart enough on semver but this seemed like a breaking change (at least it broke our code). Shouldn't the version have been bumped to 2.0? Once we knew about the problem, it was easy enough to fix, but ideally it would have never happened. I suspect it was #36 that caused the issue.
mmacaula
commented
Apr 27, 2015
|
This seems related to a bug I'm having as well. From one of the instantiated ItemViews, we used to be able to call I'm not smart enough on semver but this seemed like a breaking change (at least it broke our code). Shouldn't the version have been bumped to 2.0? Once we knew about the problem, it was easy enough to fix, but ideally it would have never happened. I suspect it was #36 that caused the issue. |
herregroen commentedMar 6, 2015
When ampersand-view created a collection-view it explicitly passes along the viewOption of "parent: this". This option is then immediately overwritten by the collection-view when it sets the parent to itself.
Either the viewOption shouldn't be passed along, with documentation that the parent property can not be set, or it should be set correctly.