/ampersand-collection

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for getting model using get(0) #50

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
3 participants
@kamilogorek @bear @lukekarrys
@kamilogorek
Member

kamilogorek commented Feb 6, 2015

Ignore only null and undefined while allowing 0 to be used as an id value.

Fixes #49

@kamilogorek kamilogorek referenced this pull request Feb 6, 2015

Closed

.get(id) can't find object with id 0 #49

@kamilogorek

This comment has been minimized.

Show comment
Hide comment
@kamilogorek

kamilogorek Feb 6, 2015

Member

Ok, now I see that I duplicated PR... #37 😭
Member

kamilogorek commented Feb 6, 2015

Ok, now I see that I duplicated PR... #37 😭

@bear bear added bug request labels Feb 6, 2015

@bear

This comment has been minimized.

Show comment
Hide comment
@bear

bear Feb 6, 2015

Contributor

If this is a dup then we should close this and could you review pull-request #37 ?
Contributor

bear commented Feb 6, 2015

If this is a dup then we should close this and could you review pull-request #37 ?
@kamilogorek

This comment has been minimized.

Show comment
Hide comment
@kamilogorek

kamilogorek Feb 6, 2015

Member

@bear definitely. I +1'd #37 and waiting for an approval. We can close this one after latter get merged.
Member

kamilogorek commented Feb 6, 2015

@bear definitely. I +1'd #37 and waiting for an approval. We can close this one after latter get merged.

@bear bear added the triage label Feb 9, 2015

@lukekarrys

This comment has been minimized.

Show comment
Hide comment
@lukekarrys

lukekarrys Mar 26, 2015

Contributor

Closing since #37 was merged
Contributor

lukekarrys commented Mar 26, 2015

Closing since #37 was merged

@lukekarrys lukekarrys closed this Mar 26, 2015

@bear bear deleted the zero-indexed-get branch Mar 26, 2015

@bear bear removed the triage label Mar 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment