/ampersand-form-view

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add precommit-hook and phantomjs to devDeps #31

Merged
merged 1 commit into from Feb 24, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
4 participants
@lukekarrys @kamilogorek @wraithgar @bear
@lukekarrys
Contributor

lukekarrys commented Feb 24, 2015

  • Add precommit-hook and jshint to match other modules
  • Needs phantomjs as a devDep so it doesnt need to be globally installed to run tests

@lukekarrys lukekarrys referenced this pull request Feb 24, 2015

Merged

more tests (work in progress) #30

@kamilogorek

This comment has been minimized.

Show comment
Hide comment
@kamilogorek

kamilogorek Feb 24, 2015

Member

👍
Member

kamilogorek commented Feb 24, 2015

👍
@wraithgar

This comment has been minimized.

Show comment
Hide comment
@wraithgar

wraithgar Feb 24, 2015

Member

Yes thank you +1
Member

wraithgar commented Feb 24, 2015

Yes thank you +1

lukekarrys added a commit that referenced this pull request Feb 24, 2015

@lukekarrys
Merge pull request #31 from AmpersandJS/dev-deps 
add precommit-hook and phantomjs to devDeps
a7f9cc2

@lukekarrys lukekarrys merged commit a7f9cc2 into master Feb 24, 2015
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@lukekarrys lukekarrys deleted the dev-deps branch Feb 24, 2015

@bear bear added enhancement request labels Feb 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment