/ampersand-input-view

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs for `required` default #34

Merged
merged 1 commit into from Dec 27, 2014

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
2 participants
@tnguyen14 @bear
@tnguyen14
Contributor

tnguyen14 commented Dec 25, 2014

required attribute is default to true, not false, as per this line https://github.com/tnguyen14/ampersand-input-view/blob/master/ampersand-input-view.js#L81.

updating doc to reflect this.

the other option is to change the code to have required set to false by default as per the doc.
@tnguyen14
update docs for `required` default 
`required` attribute is default to `true`, not `false`
54600eb

@bear bear added documentation request labels Dec 27, 2014

bear added a commit that referenced this pull request Dec 27, 2014

@bear
Merge pull request #34 from tnguyen14/master 
update docs for `required` default
ec3dc5c

@bear bear merged commit ec3dc5c into AmpersandJS:master Dec 27, 2014
1 check passed

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment