patch and wait

[yallups]

I am noticing a potential issue in the last lines of the model's save function. When I try to make a patch and I also want to wait to make the changes such as:

model.save({ 
    /*attrs*/
}, {
    patch: true,
    wait: true
}

the attrs set in sync are set to the serialization to the model.

        if (method === 'patch') options.attrs = attrs;
        // if we're waiting we haven't actually set our attributes yet so
        // we need to do make sure we send right data
        if (options.wait) options.attrs = _.extend(model.serialize(), attrs);
        xhr = this.sync(method, this, options);

        return xhr;

if I am sending a patch I definitely don't want to send over EVERYTHING that is attached to my model but maybe I am missing a point here.

[mikehedman]

I'd vote for switching the "enhancement" label with a "bug" label :)
As the code is working now, it's not in agreement with the documentation (and I think the documentation is right).

[mikehedman]

I'd vote for switching the "enhancement" label with a "bug" label :)
As the code is working now, it's not in agreement with the documentation (and I think the documentation is right).

[aaronmccall]

👍

[aaronmccall]

👍