/ampersand-model

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace underscore with standalone lodash modules; relegate underscore t... #43

Merged
merged 2 commits into from Mar 30, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
5 participants
@dhritzkiv @lukekarrys @wraithgar @kamilogorek @bear
@dhritzkiv
Contributor

dhritzkiv commented Mar 26, 2015

...o be a devDependency (for tests)

As per http://blog.andyet.com/2015/03/25/amped-down

@bear bear added enhancement request labels Mar 26, 2015

@lukekarrys

This comment has been minimized.

Show comment
Hide comment
@lukekarrys

lukekarrys Mar 26, 2015

Contributor

What do we think about dropping underscore from devDeps and using lodash there? I'm concerned about underscores lack of semver breaking tests in the future.
Contributor

lukekarrys commented Mar 26, 2015

What do we think about dropping underscore from devDeps and using lodash there? I'm concerned about underscores lack of semver breaking tests in the future.
@wraithgar

This comment has been minimized.

Show comment
Hide comment
@wraithgar

wraithgar Mar 27, 2015

Member

+1
Member

wraithgar commented Mar 27, 2015

+1
@kamilogorek

This comment has been minimized.

Show comment
Hide comment
@kamilogorek

kamilogorek Mar 28, 2015

Member

Looks good.
Member

kamilogorek commented Mar 28, 2015

Looks good.

wraithgar added a commit that referenced this pull request Mar 30, 2015

@wraithgar
Merge pull request #43 from dhritzkiv/lodash 
replace underscore with standalone lodash modules; relegate underscore t...
7224bec

@wraithgar wraithgar merged commit 7224bec into AmpersandJS:master Mar 30, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wraithgar

This comment has been minimized.

Show comment
Hide comment
@wraithgar

wraithgar Mar 30, 2015

Member

published as v5.0.1
Member

wraithgar commented Mar 30, 2015

published as v5.0.1

@dhritzkiv dhritzkiv deleted the dhritzkiv:lodash branch Aug 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment