/ampersand-select-view

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.0 RC #36

Merged
merged 2 commits into from Mar 27, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
4 participants
@cdaringe @kamilogorek @wraithgar @bear
@cdaringe
Member

cdaringe commented Mar 24, 2015

tldr: this PR is large. we can setup core-crew talky to go over this change if desired.

This PR fixes #5. It addresses a variety of other opens as well.

Per the new README.md changelog:

changelog

  1. Improve general option edge cases, and add supporting test cases. Primarily targets falsy option value handling.
  2. Validate immediately to assist when parent FormView tests onload for field validity. Update skipValidation to skipValidationMessage, permit immediate validation, but conditionally display messages.
  3. Throw an Error when trying to setValue(value) and an option matching the requested value does not exist. The exception to this is when the provided value is null, undefined, or '', and a null option value exists. Because the DOM can only recognize a single empty value for any <option>, which is the empty string '', only a single empty-ish option can only be supported by the view.
  4. Support 0 value options, both in Model id's and array values.
  5. Add eagerValidate.
  6. Denote a plan for 4.x release
  7. bulk update README, and some cody tidying

@bear bear added enhancement request breaking labels Mar 25, 2015

@kamilogorek

This comment has been minimized.

Show comment
Hide comment
@kamilogorek

kamilogorek Mar 26, 2015

Member

Wooh! Such a great work out here @cdaringe!
You're right that this PR is huge, but after quick scan everything looks really good.
Member

kamilogorek commented Mar 26, 2015

Wooh! Such a great work out here @cdaringe!
You're right that this PR is huge, but after quick scan everything looks really good.
@cdaringe

This comment has been minimized.

Show comment
Hide comment
@cdaringe

cdaringe Mar 26, 2015

Member

thanks @kamilogorek. what did you think of this class change? I'm not 100% on that.
Member

cdaringe commented Mar 26, 2015

thanks @kamilogorek. what did you think of this class change? I'm not 100% on that.
@wraithgar

This comment has been minimized.

Show comment
Hide comment
@wraithgar

wraithgar Mar 26, 2015

Member

Typically you have a single class name for things like that, regardless of input type. See things like bootstrap or foundation for examples.
Member

wraithgar commented Mar 26, 2015

Typically you have a single class name for things like that, regardless of input type. See things like bootstrap or foundation for examples.
@cdaringe

This comment has been minimized.

Show comment
Hide comment
@cdaringe

cdaringe Mar 27, 2015

Member

thanks gar. i reverted those classes back
Member

cdaringe commented Mar 27, 2015

thanks gar. i reverted those classes back

@nickryall nickryall referenced this pull request Mar 27, 2015

Closed

Fix for #23 and other updates #32

README.md
## credits
Written by [@philip_roberts](twitter.com/philip_roberts).
Lead Maintainer: [Christopher Dieringer (@cdaringe)](https://github.com/cdaringe)

This comment has been minimized.

Show comment
Hide comment
@wraithgar

wraithgar Mar 27, 2015

Member

We're putting lead right under the title, a la hapijs style.
Copy link
@wraithgar

wraithgar Mar 27, 2015

Member

We're putting lead right under the title, a la hapijs style.
package.json
@@ -1,12 +1,13 @@
{
"name": "ampersand-select-view",
"description": "A view module for intelligently rendering and validating selectbox input. Works well with ampersand-form-view.",
"version": "2.4.2",
"version": "3.0.0",

This comment has been minimized.

Show comment
Hide comment
@wraithgar

wraithgar Mar 27, 2015

Member

I try to let npm cli bump the version number, so this line can be reverted.
Copy link
@wraithgar

wraithgar Mar 27, 2015

Member

I try to let npm cli bump the version number, so this line can be reverted.
@wraithgar

This comment has been minimized.

Show comment
Hide comment
@wraithgar

wraithgar Mar 27, 2015

Member

Travis is having problems today, tests pass fine locally.
Member

wraithgar commented Mar 27, 2015

Travis is having problems today, tests pass fine locally.

@wraithgar wraithgar merged commit 8d9f5ec into AmpersandJS:master Mar 27, 2015
1 check failed

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@wraithgar

This comment has been minimized.

Show comment
Hide comment
@wraithgar

wraithgar Mar 27, 2015

Member

Published as v3.0.0
Member

wraithgar commented Mar 27, 2015

Published as v3.0.0

@cdaringe cdaringe deleted the cdaringe:3.0.0 branch Mar 27, 2015

@nickryall nickryall referenced this pull request Mar 28, 2015

Closed

reset() method for use with ampersand-form-view #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment