Mixin properties get deleted upon being mixed in, making reuse frustrating

[mmacaula]

Consider this code, requirebin example here

var State = require('ampersand-state');

var Selected = {
  session : {
    selected : 'boolean'
  }
}

var Widget = State.extend(Selected,{});
console.log("Selected.session is deleted!! :", Selected); // empty object
var Sproket = State.extend(Selected,{});         

var widget = new Widget({selected : true});

var sproket = new Sproket({selected : true});

console.log('widget is selected: ', widget.selected);   // true
console.log('sproket is selected: ', sproket.selected);  // undefined

I'm guessing the reason State is deleteing the definition is so that you don't have the definitions available as first-class properties on instantiated models. But I'm trying to make reusable mixins and use them across several types of State's and now I'm having to _.clone or wrap them in a function. It would be nice if State did this for me.

I would be happy to submit a PR with tests if you think I'm on the right track.

[lukekarrys]

@mmacaula Thanks for the issue! I remember hearing about this issue before and found some minor discussion in #68. So I definitely think you're on the right track and we should support objects not being modified when passed to State.extend.

[lukekarrys]

@mmacaula Thanks for the issue! I remember hearing about this issue before and found some minor discussion in #68. So I definitely think you're on the right track and we should support objects not being modified when passed to State.extend.

[latentflip]

Fixed in #111, released as 4.4.1

[latentflip]

Fixed in #111, released as 4.4.1