/ampersand-state

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace underscore with standalone lodash modules #150

Merged
merged 2 commits into from Mar 27, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
5 participants
@dhritzkiv @latentflip @wraithgar @pgilad @bear
@dhritzkiv
Contributor

dhritzkiv commented Mar 27, 2015

As per http://blog.andyet.com/2015/03/25/amped-down
@latentflip

latentflip reviewed Mar 27, 2015
View changes

Show outdated Hide outdated ampersand-state.js
ampersand-state.js
@@ -537,17 +561,17 @@ function createPropertyDefinition(object, name, desc, isSession) {
this.set(name, val);
},
get: function () {
var result = this._values[name];
var value = this._values[name];

This comment has been minimized.

Show comment
Hide comment
@latentflip

latentflip Mar 27, 2015

Contributor

Was there a reason to change this?
Copy link
@latentflip

latentflip Mar 27, 2015

Contributor

Was there a reason to change this?

This comment has been minimized.

Show comment
Hide comment
@pgilad

pgilad Mar 27, 2015

Member

I'm guessing because result is used by the lodash module...
i.e var result = require("lodash.result"); at the top
Copy link
@pgilad

pgilad Mar 27, 2015

Member

I'm guessing because result is used by the lodash module...
i.e var result = require("lodash.result"); at the top

This comment has been minimized.

Show comment
Hide comment
@dhritzkiv

dhritzkiv Mar 27, 2015

Contributor

^ yes, this is why.
Copy link
@dhritzkiv

dhritzkiv Mar 27, 2015

Contributor

^ yes, this is why.

This comment has been minimized.

Show comment
Hide comment
@latentflip

latentflip Mar 27, 2015

Contributor

Okay, yes I guess that helps disambiguate at least. Thanks
Copy link
@latentflip

latentflip Mar 27, 2015

Contributor

Okay, yes I guess that helps disambiguate at least. Thanks
@latentflip

This comment has been minimized.

Show comment
Hide comment
@latentflip

latentflip Mar 27, 2015

Contributor

Thanks! Added a couple of comments.
Contributor

latentflip commented Mar 27, 2015

Thanks! Added a couple of comments.

@bear bear added enhancement request labels Mar 27, 2015

@wraithgar

This comment has been minimized.

Show comment
Hide comment
@wraithgar

wraithgar Mar 27, 2015

Member

+1
Member

wraithgar commented Mar 27, 2015

+1

This was referenced Mar 27, 2015

Closed
Merged
@latentflip

This comment has been minimized.

Show comment
Hide comment
@latentflip

latentflip Mar 27, 2015

Contributor

+1
Contributor

latentflip commented Mar 27, 2015

+1

latentflip added a commit that referenced this pull request Mar 27, 2015

@latentflip
Merge pull request #150 from dhritzkiv/lodash 
replace underscore with standalone lodash modules
896e4d9

@latentflip latentflip merged commit 896e4d9 into AmpersandJS:master Mar 27, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@latentflip

This comment has been minimized.

Show comment
Hide comment
@latentflip

latentflip Mar 27, 2015

Contributor

Thanks @dhritzkiv !
Contributor

latentflip commented Mar 27, 2015

Thanks @dhritzkiv !
@dhritzkiv

This comment has been minimized.

Show comment
Hide comment
@dhritzkiv

dhritzkiv Mar 27, 2015

Contributor

No probs. I'll try to get a few more @AmpersandJS modules converted over the next few days.
Contributor

dhritzkiv commented Mar 27, 2015

No probs. I'll try to get a few more @AmpersandJS modules converted over the next few days.

@dhritzkiv dhritzkiv deleted the dhritzkiv:lodash branch Mar 27, 2015

@wraithgar

This comment has been minimized.

Show comment
Hide comment
@wraithgar

wraithgar Mar 27, 2015

Member

@latentflip you gonna patch release this?
Member

wraithgar commented Mar 27, 2015

@latentflip you gonna patch release this?
@wraithgar

This comment has been minimized.

Show comment
Hide comment
@wraithgar

wraithgar Mar 31, 2015

Member

released as 4.4.6
Member

wraithgar commented Mar 31, 2015

released as 4.4.6
@latentflip

This comment has been minimized.

Show comment
Hide comment
@latentflip

latentflip Mar 31, 2015

Contributor

Thanks @wraithgar 🎉
Contributor

latentflip commented Mar 31, 2015

Thanks @wraithgar 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment