Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to reflect behavioural changes in `set` #228

Merged
merged 3 commits into from Jan 29, 2016

Conversation

@dhritzkiv
Copy link
Contributor

dhritzkiv commented Jan 28, 2016

This PR, along with a major semver change, closes #226

This PR, along with a major semver change, closes #226
README.md Outdated
@@ -622,6 +622,8 @@ Possible options (when using `state.set()`):
* `silent` {Boolean} - prevents triggering of any change events as a result of the set operation.
* `unset` {Boolean} - `unset` the attributes keyed in the attributes object instead of setting them.
_Note: when passing an object as the `attributes` argument, only that object's own enumerable properties (i.e. those that can be accessed with `Object.keys(object)` are read and set. This behavious is new as of v5.0.0, as prior version relied on `for...in` to access an object's properties, both owned by that object and those inherited through the prototypal chain._

This comment has been minimized.

Copy link
@cdaringe

cdaringe Jan 28, 2016

Member

behaviou r, 🐣

This comment has been minimized.

Copy link
@dhritzkiv

dhritzkiv Jan 28, 2016

Author Contributor

whoops

dhritzkiv added 2 commits Jan 28, 2016
@wraithgar

This comment has been minimized.

Copy link
Contributor

wraithgar commented Jan 28, 2016

lgtm, shipping this as a major should also coincide w/ a deprecation of both 4.9.0 and 4.9.1 imo

@lukekarrys

This comment has been minimized.

Copy link
Contributor

lukekarrys commented Jan 29, 2016

+1 agree with @wraithgar

wraithgar added a commit that referenced this pull request Jan 29, 2016
Update README to reflect behavioural changes in `set`
@wraithgar wraithgar merged commit c813b2d into AmpersandJS:master Jan 29, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
coverage/coveralls Coverage decreased (-0.0%) to 97.722%
Details
@wraithgar

This comment has been minimized.

Copy link
Contributor

wraithgar commented Jan 29, 2016

Published as v5.0.0

Deprecated v4.9.0 and v4.9.1 with message to either pin back at v4.8.2 or upgrade to ^5.0.0

@dhritzkiv

This comment has been minimized.

Copy link
Contributor Author

dhritzkiv commented Jan 29, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.