New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate in favor of constituent libraries #43

Closed
wraithgar opened this Issue Mar 27, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@wraithgar

This comment has been minimized.

Show comment
Hide comment
@wraithgar

wraithgar Mar 27, 2015

Member

And move issues to appropriate repos.

Member

wraithgar commented Mar 27, 2015

And move issues to appropriate repos.

@wraithgar

This comment has been minimized.

Show comment
Hide comment
@wraithgar

wraithgar Apr 1, 2015

Member

After discussing this with @legastero it seems that we should just deprecate this module and encourage people to use these two libraries instead. The alternative is to return a paginated filtered subcollection if we need both and that would mean that the filter manipulation functions would be lost to the end user. It's easy enough to use either of what you need instead.

I'll be merging #47 still, but after that I think I'll be making a README pr that explains that this lib is slow and had to be broken into the two modules above.

Member

wraithgar commented Apr 1, 2015

After discussing this with @legastero it seems that we should just deprecate this module and encourage people to use these two libraries instead. The alternative is to return a paginated filtered subcollection if we need both and that would mean that the filter manipulation functions would be lost to the end user. It's easy enough to use either of what you need instead.

I'll be merging #47 still, but after that I think I'll be making a README pr that explains that this lib is slow and had to be broken into the two modules above.

@wraithgar wraithgar changed the title from Refactor to use constituent libraries to Depricate in favor of constituent libraries Apr 1, 2015

@wraithgar wraithgar changed the title from Depricate in favor of constituent libraries to Deprecate in favor of constituent libraries Apr 1, 2015

@wraithgar wraithgar closed this in #50 Apr 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment