Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDeprecate in favor of constituent libraries #43
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
And move issues to appropriate repos. |
bear
added
the
enhancement
label
Mar 27, 2015
This was referenced Apr 1, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
wraithgar
Apr 1, 2015
Member
After discussing this with @legastero it seems that we should just deprecate this module and encourage people to use these two libraries instead. The alternative is to return a paginated filtered subcollection if we need both and that would mean that the filter manipulation functions would be lost to the end user. It's easy enough to use either of what you need instead.
I'll be merging #47 still, but after that I think I'll be making a README pr that explains that this lib is slow and had to be broken into the two modules above.
|
After discussing this with @legastero it seems that we should just deprecate this module and encourage people to use these two libraries instead. The alternative is to return a paginated filtered subcollection if we need both and that would mean that the filter manipulation functions would be lost to the end user. It's easy enough to use either of what you need instead. I'll be merging #47 still, but after that I think I'll be making a README pr that explains that this lib is slow and had to be broken into the two modules above. |
wraithgar commentedMar 27, 2015
https://github.com/AmpersandJS/ampersand-filtered-subcollection
https://github.com/AmpersandJS/ampersand-paginated-subcollection