/ampersand-version

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'global' instead of 'window' for web worker compatibility #3

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ahutchings @latentflip
@ahutchings

ahutchings commented Nov 5, 2014

Fixes #2
@latentflip

This comment has been minimized.

Show comment
Hide comment
@latentflip

latentflip Nov 5, 2014

Contributor

I closed this in #4. I think it makes more sense to only attach if we're in window, since that's the only place ampersand-version is really useful. Thanks for the patch though!
Contributor

latentflip commented Nov 5, 2014

I closed this in #4. I think it makes more sense to only attach if we're in window, since that's the only place ampersand-version is really useful. Thanks for the patch though!
@ahutchings

This comment has been minimized.

Show comment
Hide comment
@ahutchings

ahutchings Nov 5, 2014

Sounds good, closing.

ahutchings commented Nov 5, 2014

Sounds good, closing.

@ahutchings ahutchings closed this Nov 5, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment