/ampersand-view-switcher

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invoke callback for async hide. #11

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ngryman @latentflip
@ngryman

ngryman commented Sep 22, 2014

When using the async version of hide, the next view is never shown. This is because cb is never called.
This PR fixes the issue.
@ngryman

This comment has been minimized.

Show comment
Hide comment
@ngryman

ngryman Sep 23, 2014

Oh, I think #10 tackles that issue.

ngryman commented Sep 23, 2014

Oh, I think #10 tackles that issue.
@latentflip

This comment has been minimized.

Show comment
Hide comment
@latentflip

latentflip Nov 5, 2014

Contributor

Yup, fixed in #10
Contributor

latentflip commented Nov 5, 2014

Yup, fixed in #10

@latentflip latentflip closed this Nov 5, 2014

@latentflip

This comment has been minimized.

Show comment
Hide comment
@latentflip

latentflip Nov 5, 2014

Contributor

Thanks though @ngryman
Contributor

latentflip commented Nov 5, 2014

Thanks though @ngryman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment