Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upreplace underscore with standalone lodash modules #108
Conversation
dhritzkiv
reviewed
Mar 27, 2015
| @@ -137,13 +146,13 @@ _.extend(View.prototype, { | ||
| remove: function () { | ||
| var parsedBindings = this._parsedBindings; | ||
| if (this.el && this.el.parentNode) this.el.parentNode.removeChild(this.el); | ||
| if (this._subviews) _.chain(this._subviews).flatten().invoke('remove'); |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
dhritzkiv
Mar 27, 2015
Contributor
Changed from using chain, as lodash's chain/base wrapper functionality is not available as a module. I figured it wasn't worth importing the whole lodash library for the ability to chain for one line, and it wasn't worth using the flattened array's forEach method, and then calling invoke on each subview passed.
dhritzkiv
Mar 27, 2015
Contributor
Changed from using chain, as lodash's chain/base wrapper functionality is not available as a module. I figured it wasn't worth importing the whole lodash library for the ability to chain for one line, and it wasn't worth using the flattened array's forEach method, and then calling invoke on each subview passed.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
+1 lgtm |
bear
added
enhancement
request
labels
Mar 27, 2015
added a commit
that referenced
this pull request
Mar 27, 2015
wraithgar
merged commit f87def3
into
AmpersandJS:master
Mar 27, 2015
1 check passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Published as |
dhritzkiv commentedMar 27, 2015
As per http://blog.andyet.com/2015/03/25/amped-down