Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow for passing templates on view initialization. Fixes #75 #76
Conversation
HenrikJoreteg
added
the
in progress
label
Nov 5, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
wraithgar
Nov 5, 2014
Member
+1 I was wrong @kamilogorek was right and also made a good PR with a test.
|
+1 I was wrong @kamilogorek was right and also made a good PR with a test. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
wraithgar
Nov 5, 2014
Member
Sorry didn't see your this.initialize comment. Definitely needs to go before because if it's set in .extend it will be present, so it needs to be present if set during init. Does that make sense?
|
Sorry didn't see your this.initialize comment. Definitely needs to go before because if it's set in .extend it will be present, so it needs to be present if set during init. Does that make sense? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
kamilogorek
Nov 5, 2014
Member
You want to set it in a way that template will be available inside initialize function right? Makes sense.
|
You want to set it in a way that template will be available inside initialize function right? Makes sense. |
bear
added
enhancement
request
labels
Nov 10, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
latentflip
Nov 12, 2014
Contributor
+1 it'd have been nice if template was already a prop, but meh, we shouldn't be binding to it ever so I'm okay enough with this.
|
+1 it'd have been nice if template was already a prop, but meh, we shouldn't be binding to it ever so I'm okay enough with this. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Is this ready to go then? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Looks like it is. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@kamilogorek wanna do the honours then? :) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
kamilogorek
Nov 12, 2014
Member
@latentflip I don't have npm accesses to release it, so feel free to do that :)
|
@latentflip I don't have npm accesses to release it, so feel free to do that :) |
added a commit
that referenced
this pull request
Nov 26, 2014
latentflip
merged commit f5488e6
into
AmpersandJS:master
Nov 26, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Released at 7.2.0 |
kamilogorek commentedNov 5, 2014
Issue mentioned here #75
What I'm only not quite sure is whether we should make it prior or after
initializefunction itself.