New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better check for parent reference #92

Merged
merged 1 commit into from Apr 15, 2015

Conversation

Projects
None yet
5 participants
@tnguyen14
Contributor

tnguyen14 commented Jan 6, 2015

this is an attempt to fix #90, which cause a subview to not have a reference to its parent because registerSubview is called before renderSubview, and at this point, the view.el is not defined yet.

this was probably due to a check introduced earlier to not repeatedly assign the parent reference for views rendered with renderCollection. that comment is taken out in this PR.

this fix is suggested by @aaronmccall.

@bear bear added request bug labels Jan 6, 2015

@kamilogorek

This comment has been minimized.

Show comment
Hide comment
@kamilogorek

kamilogorek Jan 6, 2015

Member

Looks good to me.

Member

kamilogorek commented Jan 6, 2015

Looks good to me.

@aaronmccall

This comment has been minimized.

Show comment
Hide comment
@aaronmccall

aaronmccall commented Jan 8, 2015

👍

@tnguyen14

This comment has been minimized.

Show comment
Hide comment
@tnguyen14

tnguyen14 Apr 13, 2015

Contributor

any thought on when this will be merged?

Contributor

tnguyen14 commented Apr 13, 2015

any thought on when this will be merged?

@kamilogorek

This comment has been minimized.

Show comment
Hide comment
@kamilogorek
Member

kamilogorek commented Apr 15, 2015

latentflip added a commit that referenced this pull request Apr 15, 2015

Merge pull request #92 from tnguyen14/master
better check for parent reference

@latentflip latentflip merged commit d7ebc49 into AmpersandJS:master Apr 15, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@latentflip

This comment has been minimized.

Show comment
Hide comment
@latentflip

latentflip Apr 15, 2015

Contributor

How about now ;)

Contributor

latentflip commented Apr 15, 2015

How about now ;)

@kamilogorek

This comment has been minimized.

Show comment
Hide comment
@kamilogorek

kamilogorek Apr 15, 2015

Member

Thanks :)

Member

kamilogorek commented Apr 15, 2015

Thanks :)

@tnguyen14

This comment has been minimized.

Show comment
Hide comment
@tnguyen14

tnguyen14 Apr 16, 2015

Contributor

Thank you so much! :) that's awesome.

Contributor

tnguyen14 commented Apr 16, 2015

Thank you so much! :) that's awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment