Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upbetter check for parent reference #92
Conversation
bear
added
request
bug
labels
Jan 6, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Looks good to me. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
aaronmccall
commented
Jan 8, 2015
|
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
any thought on when this will be merged? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
added a commit
that referenced
this pull request
Apr 15, 2015
latentflip
merged commit d7ebc49
into
AmpersandJS:master
Apr 15, 2015
1 check passed
continuous-integration/travis-ci
The Travis CI build passed
Details
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
How about now ;) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Thanks :) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Thank you so much! :) that's awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
tnguyen14 commentedJan 6, 2015
this is an attempt to fix #90, which cause a subview to not have a reference to its parent because
registerSubviewis called beforerenderSubview, and at this point, theview.elis not defined yet.this was probably due to a check introduced earlier to not repeatedly assign the
parentreference for views rendered withrenderCollection. that comment is taken out in this PR.this fix is suggested by @aaronmccall.