Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upChecks if the default is not already prevented in the link click event #71
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
+1 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
kamilogorek
Nov 5, 2014
Member
+1, but I don't think it's necessary to create a new release for this small change now and it can be published along some other changes
|
+1, but I don't think it's necessary to create a new release for this small change now and it can be published along some other changes |
added a commit
that referenced
this pull request
Nov 5, 2014
kamilogorek
merged commit 65e9a6a
into
AmpersandJS:master
Nov 5, 2014
chesles
referenced this pull request
Dec 22, 2014
Closed
global link click listener steals middle-clicks #86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ruiramos commentedNov 5, 2014
If we're preventing the default of a local link, we won't want to call navigate.
This could be solved calling stopPropagation on the other handler, but then we'll potentially lose behaviour. (needed this when using a bootstrap dropdown, handling the click on the options which are a tags)