Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upNow works with hapi 8 and the latest moonboots_hapi #87
Conversation
geek
added some commits
Jan 6, 2015
bear
added
enhancement
request
labels
Jan 6, 2015
wraithgar
reviewed
Jan 6, 2015
| }); | ||
| // require moonboots_hapi plugin | ||
| server.pack.register({plugin: require('moonboots_hapi'), options: moonbootsConfig}, function (err) { | ||
| server.register({ register: require('moonboots_hapi').register, options: moonbootsConfig }, function (err) { |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
geek
Jan 6, 2015
Contributor
It is in hapi 8: http://hapijs.com/api#serverregisterplugins-options-callback
If you change moonboots_hapi to module.exports the register function it won't be though: https://github.com/wraithgar/moonboots_hapi/blob/master/index.js#L43
geek
Jan 6, 2015
Contributor
It is in hapi 8: http://hapijs.com/api#serverregisterplugins-options-callback
If you change moonboots_hapi to module.exports the register function it won't be though: https://github.com/wraithgar/moonboots_hapi/blob/master/index.js#L43
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
wraithgar
Jan 6, 2015
Member
Yep you're right, it works the other way too but the docs show your way.
wraithgar
Jan 6, 2015
Member
Yep you're right, it works the other way too but the docs show your way.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
+1 visual w/ only one minor nitpick |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Interested in a |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
wraithgar
Jan 6, 2015
Member
My gut feeling is that is more of an examples addition, this demo app is supposed to just do a quick wireframe so people can see the basics of ampersand code itself.
|
My gut feeling is that is more of an examples addition, this demo app is supposed to just do a quick wireframe so people can see the basics of ampersand code itself. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
geek
Jan 6, 2015
Contributor
Sounds good. Might as well remove the travis integration with this repo then.
|
Sounds good. Might as well remove the travis integration with this repo then. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
fyockm
Jan 6, 2015
Member
@bear should travis be removed from this repo?
@wraithgar did you mean that this repo should not be updated to hapi 8?
|
@bear should travis be removed from this repo? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bear
Jan 6, 2015
Contributor
@fyockm yes, please do remove it - it got added by one of my automation scripts that I've yet tweaked to have per repo exclusions for integrations
/edit I just removed it - sorry for the noise
|
@fyockm yes, please do remove it - it got added by one of my automation scripts that I've yet tweaked to have per repo exclusions for integrations /edit I just removed it - sorry for the noise |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@fyockm =this repo should definitely be updated to hapi8 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
fyockm
Jan 6, 2015
Member
@wraithgar ok, I must have misunderstood your comment. So what did you mean should be an examples addition? The travis.yml?
|
@wraithgar ok, I must have misunderstood your comment. So what did you mean should be an |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
wraithgar
Jan 6, 2015
Member
Yeah, unless I'm misunderstanding what that file will do (which is very likely)
|
Yeah, unless I'm misunderstanding what that file will do (which is very likely) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
fyockm
Jan 7, 2015
Member
@wraithgar we have disabled travis in the AmpersandJS/examples repo, as tests are not required with submitted examples. it might be a good idea to ask for tests with the examples, but I think we didn't want to stifle contribution from the community (at least in the beginning).
|
@wraithgar we have disabled travis in the AmpersandJS/examples repo, as tests are not required with submitted examples. it might be a good idea to ask for tests with the examples, but I think we didn't want to stifle contribution from the community (at least in the beginning). |
added a commit
that referenced
this pull request
Jan 7, 2015
bear
merged commit f2fa00c
into
AmpersandJS:master
Jan 7, 2015
1 check failed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Thank you @geek! |
geek commentedJan 6, 2015
Closes #85