From d5c5e604ad5a62bb6496005983953a606b16d549 Mon Sep 17 00:00:00 2001 From: Jason Kulatunga Date: Sun, 26 Aug 2018 22:19:32 -0700 Subject: [PATCH] cleanup of old test suite. --- pkg/engine/engine_golang_test.go | 13 ----------- pkg/engine/engine_node_test.go | 39 -------------------------------- pkg/engine/engine_ruby_test.go | 15 ------------ 3 files changed, 67 deletions(-) diff --git a/pkg/engine/engine_golang_test.go b/pkg/engine/engine_golang_test.go index 6f6512f..ed8abc7 100644 --- a/pkg/engine/engine_golang_test.go +++ b/pkg/engine/engine_golang_test.go @@ -286,16 +286,3 @@ func (suite *EngineGolangTestSuite) TestEngineGolang_PackageStep_WithoutLockFile require.NoError(suite.T(), berr) require.False(suite.T(), utils.FileExists(path.Join(suite.PipelineData.GitLocalPath, "glide.lock"))) } - -func (suite *EngineGolangTestSuite) TestEngineGolang_DistStep() { - //setup - suite.Config.EXPECT().SetDefault(gomock.Any(), gomock.Any()).MinTimes(1) - golangEngine, err := engine.Create("golang", suite.PipelineData, suite.Config, suite.Scm) - require.NoError(suite.T(), err) - - //test - berr := golangEngine.DistStep() - - //assert - require.NoError(suite.T(), berr) -} diff --git a/pkg/engine/engine_node_test.go b/pkg/engine/engine_node_test.go index dc1d2f8..0481398 100644 --- a/pkg/engine/engine_node_test.go +++ b/pkg/engine/engine_node_test.go @@ -135,30 +135,6 @@ func (suite *EngineNodeTestSuite) TestEngineNode_AssembleStep_WithoutPackageJson require.Error(suite.T(), berr, "should return an error") } -func (suite *EngineNodeTestSuite) TestEngineNode_DependenciesStep() { - //setup - suite.Config.EXPECT().SetDefault(gomock.Any(), gomock.Any()).MinTimes(1) - - //copy cookbook fixture into a temp directory. - parentPath, err := ioutil.TempDir("", "") - require.NoError(suite.T(), err) - defer os.RemoveAll(parentPath) - suite.PipelineData.GitParentPath = parentPath - suite.PipelineData.GitLocalPath = path.Join(parentPath, "npm_analogj_test") - cerr := utils.CopyDir(path.Join("testdata", "node", "npm_analogj_test"), suite.PipelineData.GitLocalPath) - require.NoError(suite.T(), cerr) - - nodeEngine, err := engine.Create("node", suite.PipelineData, suite.Config, suite.Scm) - require.NoError(suite.T(), err) - - //test - berr := nodeEngine.DependenciesStep() - - //assert - require.NoError(suite.T(), berr) - require.True(suite.T(), utils.FileExists(path.Join(suite.PipelineData.GitLocalPath, "npm-shrinkwrap.json"))) -} - func (suite *EngineNodeTestSuite) TestEngineNode_TestStep_AllDisabled() { //setup suite.Config.EXPECT().SetDefault(gomock.Any(), gomock.Any()).MinTimes(1) @@ -287,18 +263,3 @@ func (suite *EngineNodeTestSuite) TestEngineNode_PackageStep_WithoutLockFiles() require.NoError(suite.T(), berr) require.False(suite.T(), utils.FileExists(path.Join(suite.PipelineData.GitLocalPath, "npm-shrinkwrap.json"))) } - -func (suite *EngineNodeTestSuite) TestEngineNode_DistStep_WithoutCredentials() { - //setup - suite.Config.EXPECT().SetDefault(gomock.Any(), gomock.Any()).MinTimes(1) - suite.Config.EXPECT().IsSet("npm_auth_token").MinTimes(1).Return(false) - - nodeEngine, err := engine.Create("node", suite.PipelineData, suite.Config, suite.Scm) - require.NoError(suite.T(), err) - - //test - berr := nodeEngine.DistStep() - - //assert - require.Error(suite.T(), berr) -} diff --git a/pkg/engine/engine_ruby_test.go b/pkg/engine/engine_ruby_test.go index cdf4119..ced37d2 100644 --- a/pkg/engine/engine_ruby_test.go +++ b/pkg/engine/engine_ruby_test.go @@ -293,18 +293,3 @@ func (suite *EngineRubyTestSuite) TestEngineRuby_PackageStep_WithoutLockFiles() require.NoError(suite.T(), berr) require.False(suite.T(), utils.FileExists(path.Join(suite.PipelineData.GitLocalPath, "Gemfile.lock"))) } - -func (suite *EngineRubyTestSuite) TestEngineRuby_DistStep_WithoutCredentials() { - //setup - suite.Config.EXPECT().SetDefault(gomock.Any(), gomock.Any()).MinTimes(1) - suite.Config.EXPECT().IsSet("rubygems_api_key").MinTimes(1).Return(false) - - rubyEngine, err := engine.Create("ruby", suite.PipelineData, suite.Config, suite.Scm) - require.NoError(suite.T(), err) - - //test - berr := rubyEngine.DistStep() - - //assert - require.Error(suite.T(), berr) -}