Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Apply styles to photogrammetry #7255
Thanks for the pull request @lilleyse!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
This is awesome @lilleyse ! I can run my original transparency demo from the forum thread now. All tests are passing, and works in Chrome, Edge and IE11.
The only thing I feel uneasy about is:
Since that means photogrammetry wouldn't be able to use time-based styles, and it would be kind of opaque to the user why this doesn't work. This built in time variable is only documented in the spec, and it would be strange to add to add this CesiumJS specific implementation issue there.
I guess getting that to work would require passing in the original tileset to the evaluate function? Is that a difficult refactor? It might be worth at least opening up an issue for.