/cesium

3D Tiles Sandcastle Demos #5578

Merged
merged 11 commits into from Jul 5, 2017
+906 −151

Conversation

Reviewers

@pjcozzi pjcozzi

Assignees
No one assigned
Labels
priority - next release
Projects
None yet
Milestone
No milestone
3 participants
@lilleyse @pjcozzi @rahwang
@lilleyse
Contributor

lilleyse commented Jul 3, 2017 • edited

Fixes #5506

Demos (the first 5 are also in the main Showcases tab):

  • 3D Tiles BIM (Power Plant model from Bentley)
  • 3D Tiles Point Cloud (Chappes Church)
  • 3D Tiles Photogrammetry (AGI building)
    • Some artifacts when skipLevelOfDetail is on due to thin roof walls
  • 3D Tiles Feature Picking (NYC CityGML)
  • 3D Tiles Feature Styling (NYC CityGML)
  • 3D Tiles Adjust Height (commonly requested code sample on the forum)
  • 3D Tiles Batch Table Hierarchy
  • 3D Tiles Formats (a simplified version of the original 3D Tiles demo)
  • 3D Tiles Inspector
  • 3D Tiles Interactivity (annotations, print metadata, zoom to, hide feature abilities from the original 3D Tiles demo)
  • 3D Tiles Point Cloud Styling

To do:

  • Demos still need attribution. Is a sentence at the top of the demo code sufficient?
  • Tilesets are currently hosted on my personal Composer account.

rahwang and others added some commits Jun 22, 2017

@rahwang rahwang adding nyc picking demo
cca2d01
@lilleyse lilleyse Merge pull request #5525 from rahwang/3dtile-picking-demo 
adding nyc picking demo

All checks have passed

4 successful checks
continuous-integration/travis-ci/push — The Travis CI build passed
Details
@AnalyticalGraphics
deployment — Deployed
Details
@AnalyticalGraphics
npm package — Deployed
Details
@AnalyticalGraphics
zip file — Deployed
Details
892f080
@lilleyse lilleyse Merge branch 'master' into 3d-tiles-demos

All checks have passed

4 successful checks
continuous-integration/travis-ci/push — The Travis CI build passed
Details
@AnalyticalGraphics
deployment — Deployed
Details
@AnalyticalGraphics
npm package — Deployed
Details
@AnalyticalGraphics
zip file — Deployed
Details
734c0d0
@rahwang @lilleyse rahwang nyc styling demo 96a328d
@rahwang @lilleyse rahwang switching to a few simple examples c393c59
@rahwang @lilleyse rahwang add comments e960cfc
@rahwang @lilleyse rahwang removing the time-dynamic styling for now
f0d0b3b
@lilleyse lilleyse Merge pull request #5553 from rahwang/3d-tiles-styling-demo 
3d tiles styling demo

All checks have passed

4 successful checks
continuous-integration/travis-ci/push — The Travis CI build passed
Details
@AnalyticalGraphics
deployment — Deployed
Details
@AnalyticalGraphics
npm package — Deployed
Details
@AnalyticalGraphics
zip file — Deployed
Details
475e5e2
@lilleyse lilleyse Added more 3D Tiles sandcastle demos

All checks have passed

5 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
@AnalyticalGraphics
deployment — Deployed
Details
@AnalyticalGraphics
npm package — Deployed
Details
@AnalyticalGraphics
zip file — Deployed
Details
0e749b2

pjcozzi added the priority - next release label Jul 4, 2017

@pjcozzi
Member

pjcozzi commented Jul 4, 2017

Demos still need attribution. Is a sentence at the top of the demo code sufficient?

Yes, later these may be embedded in the tileset, AnalyticalGraphicsInc/3d-tiles#55

Tilesets are currently hosted on my personal Composer account.

Please address this soon so it doesn't delay the 1.35 release tomorrow. If we can't address this by about noon, we'll ship with these urls and update in the next release.
Apps/Sandcastle/gallery/3D Tiles BIM.html
+//Sandcastle_Begin
+var viewer = new Cesium.Viewer('cesiumContainer');
+
+var tileset = viewer.scene.primitives.add(new Cesium.Cesium3DTileset({
@pjcozzi

pjcozzi Jul 4, 2017

Member

Perhaps don't put this one in a body of water?

Apps/Sandcastle/gallery/3D Tiles Point Cloud.html
+var viewer = new Cesium.Viewer('cesiumContainer');
+
+var tileset = viewer.scene.primitives.add(new Cesium.Cesium3DTileset({
+ url : 'https://beta.cesium.com/api/assets/1448?access_token=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJqdGkiOiJiODNmMjQzNy1mNGI4LTQ2ZTItOWI0NS0yZDUzMzMyNWMxNzQiLCJpZCI6OSwiaWF0IjoxNDgxODI5ODU0fQ.4fmVtksZ1CAzjPBprJ47uIuK0vr-8CcuDKM7M8a0mF4'
@pjcozzi

pjcozzi Jul 4, 2017

Member

@AnimatedRNG this is another good point cloud dataset for your testing.

@pjcozzi
Member

pjcozzi commented Jul 4, 2017

Also please add an indoor example like the San Miguel. Perhaps @likangning93 can help.
@pjcozzi
Member

pjcozzi commented Jul 5, 2017

Updated CHANGES.md in master for this. 3340d14
@lilleyse lilleyse Updated links and added attribution

All checks have passed

5 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
@AnalyticalGraphics
deployment — Deployed
Details
@AnalyticalGraphics
npm package — Deployed
Details
@AnalyticalGraphics
zip file — Deployed
Details
b377a9e
@lilleyse
Contributor

lilleyse commented Jul 5, 2017

Updated.

Also please add an indoor example like the San Miguel

After talking with @likangning93 we don't actually have similar ones that are free for us to use, besides models that are too small to be worth tiling like Sponza or the Cathedral.
@lilleyse lilleyse Added San Miguel tileset

All checks have passed

5 successful checks
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
continuous-integration/travis-ci/push — The Travis CI build passed
Details
@AnalyticalGraphics
deployment — Deployed
Details
@AnalyticalGraphics
npm package — Deployed
Details
@AnalyticalGraphics
zip file — Deployed
Details
10e63f7
@lilleyse
Contributor

lilleyse commented Jul 5, 2017

Ready with the San Miguel model under the 3D Tiles Interior name. Thanks for tiling it @likangning93.
@pjcozzi
Member

pjcozzi commented Jul 5, 2017

Looks great!

@pjcozzi pjcozzi merged commit 5838c6f into master Jul 5, 2017
5 checks passed

5 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deployment Deployed
Details
npm package Deployed
Details
zip file Deployed
Details

pjcozzi deleted the 3d-tiles-demos branch Jul 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment